Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Shared Lib Migration : sdformat #1048

Merged
merged 5 commits into from
Jul 8, 2022
Merged

ign -> gz Shared Lib Migration : sdformat #1048

merged 5 commits into from
Jul 8, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jun 14, 2022
Closed
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #1048 (f7f46ef) into main (5e40fd1) will not change coverage.
The diff coverage is 75.00%.

❗ Current head f7f46ef differs from pull request most recent head e9a8032. Consider uploading reports for the commit e9a8032 to get more accurate results

@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files         154      154           
  Lines       18682    18682           
=======================================
  Hits        15527    15527           
  Misses       3155     3155
Impacted Files Coverage Δ
usd/src/usd_parser/USDWorld.cc 58.37% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e40fd1...e9a8032. Read the comment docs.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 14, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 14, 2022
@chapulina chapulina changed the base branch from main to macro_migration June 15, 2022 16:18
@chapulina chapulina self-requested a review June 15, 2022 16:19
@methylDragon methylDragon force-pushed the shared_lib_migration branch 2 times, most recently from ecffd1c to 703a9fe Compare June 16, 2022 20:46
Base automatically changed from macro_migration to main June 18, 2022 02:01
@methylDragon methylDragon marked this pull request as ready for review June 27, 2022 21:31
@methylDragon methylDragon force-pushed the shared_lib_migration branch 2 times, most recently from 4c43147 to 1d89a50 Compare June 29, 2022 07:13
chapulina
chapulina reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, LGTM otherwise

Migration.md Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the shared_lib_migration branch 3 times, most recently from aa6640f to aade1da Compare June 29, 2022 17:00
@methylDragon methylDragon force-pushed the shared_lib_migration branch 2 times, most recently from ed6bc59 to 8adbc58 Compare July 5, 2022 19:59
@methylDragon
Migrate path to .gz
75de58a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Revert fuel cache path changes
2035005 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Tick-tock header functions
1a74086 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Hard-tock ignitionVersion -> gzVersion
010f6cf 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate shared lib references
e9a8032 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon enabled auto-merge (squash) July 7, 2022 20:39
@methylDragon methylDragon merged commit 77478ed into main Jul 8, 2022
@methylDragon methylDragon deleted the shared_lib_migration branch July 8, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina