Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed USD component from SDFormat and move to gz-usd #1094

Merged
merged 5 commits into from
Jul 30, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jul 27, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Removed USD component from SDFormat and move to gz-usd

There are some reason to move this component:

New location https://github.com/gazebosim/gz-usd

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina July 27, 2022 22:53
@ahcorde ahcorde self-assigned this Jul 27, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1094 (68f6627) into sdf12 (f776995) will increase coverage by 4.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            sdf12    #1094      +/-   ##
==========================================
+ Coverage   86.48%   91.28%   +4.80%     
==========================================
  Files         109       80      -29     
  Lines       16043    13086    -2957     
==========================================
- Hits        13874    11946    -1928     
+ Misses       2169     1140    -1029     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f776995...68f6627. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this for the warning on Jenkins:

We should also update examples/usdConverter to point to the new location. I think it's worth it keeping the example here so the old links to them still work.

There's also the test/usd directory, and these:

  • run: |
    echo "PATH=$PATH:/tmp/USD/bin" >> $GITHUB_ENV
    echo "LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/tmp/USD/lib" >> $GITHUB_ENV
    echo "CMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH:/tmp/USD" >> $GITHUB_ENV
  • ign_find_package(ignition-utils1 COMPONENTS cli REQUIRED_BY usd)

Finally, let's add notes to the migration guide explaining what a user needs to change to use the new location.

@ahcorde ahcorde force-pushed the ahcorde/remove_usd_component branch from 5a7544a to 055a240 Compare July 28, 2022 11:27
@ahcorde ahcorde requested a review from chapulina July 28, 2022 11:27
@chapulina
Copy link
Contributor

the test/usd directory

That's still there. Remove them here and make sure the tests are also present in the new repo

Migration.md Outdated Show resolved Hide resolved
examples/usdConverter/README.md Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina enabled auto-merge (squash) July 30, 2022 02:36
@chapulina chapulina merged commit b59f6e1 into sdf12 Jul 30, 2022
@chapulina chapulina deleted the ahcorde/remove_usd_component branch July 30, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress usd
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants