-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed USD component from SDFormat and move to gz-usd #1094
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## sdf12 #1094 +/- ##
==========================================
+ Coverage 86.48% 91.28% +4.80%
==========================================
Files 109 80 -29
Lines 16043 13086 -2957
==========================================
- Hits 13874 11946 -1928
+ Misses 2169 1140 -1029 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this for the warning on Jenkins:
We should also update examples/usdConverter
to point to the new location. I think it's worth it keeping the example here so the old links to them still work.
There's also the test/usd
directory, and these:
sdformat/.github/workflows/ci.yml
Lines 20 to 23 in 5a7544a
run: | echo "PATH=$PATH:/tmp/USD/bin" >> $GITHUB_ENV echo "LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/tmp/USD/lib" >> $GITHUB_ENV echo "CMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH:/tmp/USD" >> $GITHUB_ENV Line 113 in 5a7544a
ign_find_package(ignition-utils1 COMPONENTS cli REQUIRED_BY usd)
Finally, let's add notes to the migration guide explaining what a user needs to change to use the new location.
Signed-off-by: ahcorde <ahcorde@gmail.com>
5a7544a
to
055a240
Compare
That's still there. Remove them here and make sure the tests are also present in the new repo |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Removed USD component from SDFormat and move to gz-usd
There are some reason to move this component:
New location https://github.com/gazebosim/gz-usd
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.