Scene: update calls to use sdf::Errors parameters

[marcoag]

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🎉 New feature

Work towards #820.

Depends on #1162 and: #1141.

Summary

Adds missing Errors structure parameters in a few methods of the Sky class.

Test it

Using the Sky class should report all errors through sdf::Errors if the errors parameter is used, it should print them otherwise.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (sdf13@066f5a2). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head d4df54b differs from pull request most recent head 815dfa0. Consider uploading reports for the commit 815dfa0 to get more accurate results

@@           Coverage Diff            @@
##             sdf13    #1164   +/-   ##
========================================
  Coverage         ?   87.55%           
========================================
  Files            ?      126           
  Lines            ?    16476           
  Branches         ?        0           
========================================
  Hits             ?    14426           
  Misses           ?     2050           
  Partials         ?        0           

Impacted Files	Coverage Δ
src/Scene.cc	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.