Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos workflow: don't upgrade existing packages #1217

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jan 5, 2023

🦟 Bug fix

Fixes macOS CI

Summary

Set HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK environment variable to prevent upgrading preinstalled packages, since current CI builds are failing when upgrading one of the existing packages. I saw a hint for this in the console output of a failed build:

==> Upgrading 10 dependents of upgraded formulae:
Disable this behaviour by setting HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
colima 0.5.0 -> 0.5.2, composer 2.4.4 -> 2.5.1, curl 7.86.0 -> 7.87.0, imagemagick 7.1.0-54 -> 7.1.0-57, kotlin 1.7.21 -> 1.8.0, libheif 1.14.0 -> 1.14.1, libraw 0.20.2_4 -> 0.21.0, lima 0.14.1 -> 0.14.2, maven 3.8.6 -> 3.8.7, python@3.11 3.11.0 -> 3.11.1

https://github.com/gazebosim/sdformat/actions/runs/3681027316/jobs/6557385982

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Set HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK
environment variable to prevent upgrading
preinstalled packages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from ahcorde January 5, 2023 18:59
@scpeters scpeters requested a review from azeey as a code owner January 5, 2023 18:59
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #1217 (d9b3f65) into sdf9 (17953de) will not change coverage.
The diff coverage is n/a.

❗ Current head d9b3f65 differs from pull request most recent head 094bb72. Consider uploading reports for the commit 094bb72 to get more accurate results

@@           Coverage Diff           @@
##             sdf9    #1217   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files          63       63           
  Lines       10093    10093           
=======================================
  Hits         8918     8918           
  Misses       1175     1175           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters
Copy link
Member Author

scpeters commented Jan 5, 2023

actually, this doesn't quite fix it. There is a conflict when installing the brew python formula (also reported at actions/setup-python#577)

==> Installing osrf/simulation/sdformat9 dependency: python
==> Pouring python@3.10--3.10.9.monterey.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

To force the link and overwrite all conflicting files:
  brew link --overwrite python@3.10

To list all files that would be deleted:
  brew link --overwrite --dry-run python@3.10

Possible conflicting files are:
/usr/local/bin/2to3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/2to3
/usr/local/bin/idle3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/idle3
/usr/local/bin/pydoc3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/pydoc3
/usr/local/bin/python3 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3
/usr/local/bin/python3-config -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3-config
==> /usr/local/Cellar/python@3.10/3.10.9/bin/python3.10 -m ensurepip
==> /usr/local/Cellar/python@3.10/3.10.9/bin/python3.10 -m pip install -v --no-d
==> Summary

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

scpeters commented Jan 5, 2023

trying a workaround in 094bb72

@ahcorde
Copy link
Collaborator

ahcorde commented Jan 5, 2023

@scpeters did you launch a new job ?

@scpeters
Copy link
Member Author

scpeters commented Jan 5, 2023

@scpeters did you launch a new job ?

it is passing now

https://github.com/gazebosim/sdformat/actions/runs/3849859656/jobs/6559340034

@scpeters
Copy link
Member Author

scpeters commented Jan 6, 2023

trying a workaround in 094bb72

I copied this workaround from RobotLocomotion/drake-external-examples#252, and it appears to be working

@scpeters scpeters merged commit 8775d0b into sdf9 Jan 6, 2023
@scpeters scpeters deleted the scpeters/fix_macos_workflow branch January 6, 2023 02:20
@scpeters scpeters mentioned this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants