Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard dependence on ruby #1323

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

mjcarroll
Copy link
Contributor

The dep will get pulled in by gz-tools

The dep will get pulled in by gz-tools

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1323 (182b3ab) into sdf14 (93f62c6) will not change coverage.
Report is 1 commits behind head on sdf14.
The diff coverage is n/a.

❗ Current head 182b3ab differs from pull request most recent head 79e4ae1. Consider uploading reports for the commit 79e4ae1 to get more accurate results

@@           Coverage Diff           @@
##            sdf14    #1323   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files         134      134           
  Lines       17751    17751           
=======================================
  Hits        15528    15528           
  Misses       2223     2223           

📢 Have feedback on the report? Share it here.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we did a lot of work to not need ruby here, so we should definitely remove this, and likewise we need to indicate that python is now required

@mjcarroll mjcarroll merged commit f6f34e2 into sdf14 Sep 7, 2023
11 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/remove_ruby_dep branch September 7, 2023 19:33
scpeters added a commit to gazebo-release/sdformat14-release that referenced this pull request Sep 8, 2023
Follow-up to gazebosim/sdformat#1323

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member

scpeters commented Sep 8, 2023

follow-up: gazebo-release/sdformat14-release#2

mjcarroll pushed a commit to gazebo-release/sdformat14-release that referenced this pull request Sep 8, 2023
Follow-up to gazebosim/sdformat#1323

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants