Improve docs of collision_bitmask. #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
|
Okay, retargeted. |
azeey
approved these changes
Mar 19, 2021
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
May 17, 2021
* added to sdf 1.7 in gazebosim#521 Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> Signed-off-by: Steve Peters <scpeters@openrobotics.org>
7 tasks
scpeters
added a commit
that referenced
this pull request
May 19, 2021
* sdf 1.8: Add <double_sided> to material from #410 * sdf 1.8: Add lightmap to 1.8 spec from #429 * sdf 1.8: document Add L16 camera pixel format from #487 Signed-off-by: Ian Chen <ichen@osrfoundation.org> * sdf 1.8: Decrease far clip lower bound from #435 Signed-off-by: Nate Koenig <nate@openrobotics.org> * sdf 1.8: Added render_order to material from #446 Signed-off-by: ahcorde <ahcorde@gmail.com> * sdf 1.8: Add camera type aliases to docs. from #514 * sdf 1.8: Improve docs of collision_bitmask from #521 Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz> * sdf 1.8: support nested models in @attached_to from #316 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
It was confusing for me reading sdformat docs to figure out what is the allowed range for
<collision_bitmask>and<category_bitmask>. So I improved the text to clearly state they are treated as 16-bit unsigned ints.Checklist
sh tools/code_check.sh)another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge