Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions and classes #622

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Jul 9, 2021

Summary

This removes all deprecated functions and classes:

  • sdf::Element::SetInclude
  • sdf::Element::GetInclude
  • sdf::Color
  • sdf::JointAxis::InitialPosition
  • sdf::JointAxis::SetInitialPosition

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 9, 2021
@azeey azeey self-assigned this Jul 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #622 (efe5ff1) into main (2d298f0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head efe5ff1 differs from pull request most recent head c9c0d86. Consider uploading reports for the commit c9c0d86 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   87.59%   87.57%   -0.02%     
==========================================
  Files          72       72              
  Lines       10513    10497      -16     
==========================================
- Hits         9209     9193      -16     
  Misses       1304     1304              
Impacted Files Coverage Δ
include/sdf/Element.hh 100.00% <ø> (ø)
include/sdf/Types.hh 100.00% <ø> (ø)
src/JointAxis.cc 96.85% <ø> (-0.17%) ⬇️
src/Element.cc 97.64% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d298f0...c9c0d86. Read the comment docs.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit 218a6f7 into gazebosim:main Jul 15, 2021
@azeey azeey deleted the remove_deprecated branch July 15, 2021 20:35
@scpeters
Copy link
Member

the ign-physics nightly build is broken since we haven't merged gazebosim/gz-physics#276 yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants