11 ➡️ 12 Forward port #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazebosim#575) Now PrintValues() and ToString() will not output the elements that were added by default during parsing. There's also the option to call them with a boolean flag that will allow the caller to decide weather they want defaults in the output or not. Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
* check for <experimental:params> & test Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * defined xml namespace Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * Param passing prototype: Retrieve specified element (gazebosim#427) * retrieve element by identifier under <experimental:params> Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * Moved updateParams before addNestedModel (gazebosim#464) * retrieve element for add action & added tests Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * replaced name with element_id Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * moved updateParams before addNestedModel Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * found chars using rfind Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * added error when element_id missing name after :: Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * updated find w/ startIdx Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> * Param passing prototype: Add action (gazebosim#546) * tinyxml2 to string helper Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * add action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * fixed codecheck errors Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * changed parser_private functions to nonstatic Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * removed specification check Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * add action requires 'name' attribute in spec Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * fixed nested include test Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * removed unused param Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * check name attr nonempty Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * storing attribute to variable Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * Param passing prototype: Remove action (gazebosim#563) * tinyxml2 to string helper Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * add action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * fixed codecheck errors Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * changed parser_private functions to nonstatic Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * removed specification check Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * remove action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * add action requires 'name' attribute in spec Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * fixed nested include test Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * removed unused param Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * check name attr nonempty Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * Param passing prototype: Replace action (gazebosim#566) * tinyxml2 to string helper Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * add action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * fixed codecheck errors Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * changed parser_private functions to nonstatic Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * removed specification check Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * remove action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * add action requires 'name' attribute in spec Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * fixed nested include test Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * removed unused param Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * check name attr nonempty Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * replace action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * renamed init element description function Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * added ParamPassing namespace Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * updated add for plugins Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * Param passing prototype: Modify action (gazebosim#577) * tinyxml2 to string helper Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * add action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * fixed codecheck errors Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * changed parser_private functions to nonstatic Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * removed specification check Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * remove action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * add action requires 'name' attribute in spec Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * fixed nested include test Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * removed unused param Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * check name attr nonempty Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * replace action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * modify action Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * code cleanup Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * added nested model test Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * readXml wrapper Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * SDFPtr to ElementPtr Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * updated test paths Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * removed nested links Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * fixed add & modify bugs Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
This moves the recently added data member `explicitlySetInFile` to the end of the `ElementPrivate` class Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
The graph data is private, so expose methods for checking that the graphs are valid. * Add tests showing graph errors Load an sdf::World or sdf::Model instead of an sdf::Root to see the graph errors. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
The graph data is private, so expose methods for checking that the graphs are valid. * Add tests showing graph errors Load an sdf::World or sdf::Model instead of an sdf::Root to see the graph errors. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merge 9 -> 10
Merge 9 -> 11
* Prepare for 11.2.2 Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Error: move << operator from .hh to .cc file Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Fix visibility Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
chapulina
approved these changes
Jul 17, 2021
Codecov Report
@@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 87.57% 87.89% +0.31%
==========================================
Files 72 72
Lines 10497 10837 +340
==========================================
+ Hits 9193 9525 +332
- Misses 1304 1312 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11 ➡️ 12 Forward port
Port
sdf11tomainBranch comparison: main...sdf11
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)