STY: change booleans from 0/1 to "false/true" #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
FirefoxMetzger
force-pushed
the
fix-boolean
branch
from
a66e505
to
d7f1ed9
Compare
FirefoxMetzger
changed the title
chapulina
approved these changes
Aug 10, 2021
|
@chapulina Jenkins seems to have broken for this run; it seems to have timed out fetching from Github initially, then tried some recovery thing (I guess), and ended up suiciding. Could you try re-running the failing test (since I doubt me changing X.sdf files will have such an effect on the CI :) ). |
|
@osrf-jenkins run tests please |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Changes all occurrences of
default="0/1"for boolean elements that I found todefault="false/true"as discussed in #653 .Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge