Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: add missing plugin element to include #675

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

FirefoxMetzger
Copy link
Contributor

As per comment in #668 ; apply the same changes to sdf9

(cherry picked from commit 232ac5c)

Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
(cherry picked from commit 232ac5c)
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Aug 25, 2021
@chapulina chapulina requested a review from azeey August 26, 2021 01:20
@codecov-commenter
Copy link

Codecov Report

Merging #675 (4b838ad) into sdf9 (e18682d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             sdf9     #675   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files          62       62           
  Lines        9734     9734           
=======================================
  Hits         8453     8453           
  Misses       1281     1281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18682d...4b838ad. Read the comment docs.

Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Gazebo classic and didn't find any regression

@azeey azeey merged commit e0d77cc into gazebosim:sdf9 Aug 30, 2021
@FirefoxMetzger FirefoxMetzger deleted the sdf9-add-missing-plugin branch August 31, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants