Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ubuntu install docs #679

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

varunagrawal
Copy link
Contributor

🦟 Bug fix

Fixes #655

Summary

Added instructions to add the correct apt repository to get sdformat binaries to install on Ubuntu.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Aug 27, 2021
Signed-off-by: Varun Agrawal <varagrawal@gmail.com>
README.md Outdated
```
```sh
sudo sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-stable `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-stable.list'
sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys D2486D2DD83DB69272AFE98867170598AF249743
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys D2486D2DD83DB69272AFE98867170598AF249743
wget http://packages.osrfoundation.org/gazebo.key -O - | sudo apt-key add -

Signed-off-by: Varun Agrawal <varagrawal@gmail.com>
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@azeey azeey dismissed ahcorde’s stale review August 30, 2021 23:59

Feedback has been addressed

@azeey azeey merged commit e1a3a93 into gazebosim:sdf11 Aug 30, 2021
@varunagrawal varunagrawal deleted the fix/ubuntu-install-docs branch August 31, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDFormat10 package not available on Ubuntu
3 participants