Use ParserConfig more in parser.cc #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from patch in RobotLocomotion/drake#16791 by jwnimmer-tri. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Require ParserConfig argument in parser.cc's private helper functions: initDoc, initXml, and _initFile. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf12 #883 +/- ##
=======================================
Coverage 88.15% 88.16%
=======================================
Files 100 100
Lines 14627 14629 +2
=======================================
+ Hits 12895 12897 +2
Misses 1732 1732
Continue to review full report at Codecov.
|
azeey
approved these changes
Mar 16, 2022
7 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of #881
Summary
As noted in #881,
ParserConfigobjects are not always propagated even when they are available. A recent partial fix for this was recently merged in #824, and a patch by @jwnimmer-tri was suggested in RobotLocomotion/drake#16791, which has been applied to this branch in 58198fa. Additionally, several private helper functions in parser.cc are updated in e92d245 to requireParserConfigobjects.There is more to do to fully resolve #881, but this is a start.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.