Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Frame Python interface #962

Merged
merged 10 commits into from
Apr 22, 2022
Merged

Added Frame Python interface #962

merged 10 commits into from
Apr 22, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 11, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of this meta ticket #931

Summary

Added Frame Python interface

Test it

from sdformat import Frame

frame = Frame()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 11, 2022
@ahcorde ahcorde self-assigned this Apr 11, 2022
@ahcorde ahcorde mentioned this pull request Apr 11, 2022
62 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 11, 2022
@ahcorde ahcorde marked this pull request as draft April 19, 2022 21:45
@ahcorde ahcorde marked this pull request as ready for review April 19, 2022 21:50
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #962 (4b27481) into main (bb84733) will not change coverage.
The diff coverage is n/a.

❗ Current head 4b27481 differs from pull request most recent head b97914f. Consider uploading reports for the commit b97914f to get more accurate results

@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb84733...b97914f. Read the comment docs.

Signed-off-by: ahcorde <ahcorde@gmail.com>
python/src/sdf/pyFrame.cc Outdated Show resolved Hide resolved
python/test/pyFrame_TEST.py Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from azeey April 21, 2022 19:08
@azeey azeey mentioned this pull request Apr 21, 2022
8 tasks
python/src/sdf/pyFrame.cc Outdated Show resolved Hide resolved
python/test/pyFrame_TEST.py Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from azeey April 22, 2022 07:59
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde merged commit bda630c into main Apr 22, 2022
@ahcorde ahcorde deleted the ahcorde/python/frame branch April 22, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants