Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.termbox already exists #11

Open
ghost opened this issue May 2, 2015 · 6 comments
Open

.termbox already exists #11

ghost opened this issue May 2, 2015 · 6 comments

Comments

@ghost
Copy link

ghost commented May 2, 2015

Building failed because python wasn't installed, which is required to build the C library. I installed python and build failed again because git wouldn't clone into an existing directory. I'll submit a pull request with a fix when I get the chance.

@rminderhoud
Copy link

clean() should be called before setup() in build.rs to fix the git clone error

bjorn-ove added a commit to bjorn-ove/termbox-sys that referenced this issue Aug 18, 2018
gchp added a commit that referenced this issue Sep 11, 2018
Run clean before setup as proposed in issue #11
@timvisee
Copy link

timvisee commented Sep 13, 2018

I got the same error, took me a while to figure out what was causing it.

On my system, /usr/bin/python is symlinked to /usr/bin/python3. Changing that symlink to /usr/bin/python2 solved the issue.

I currently can't figure out what is calling this python library though. Explicitly calling python2 (with a fallback to python) might be a good solution. Because I didn't find this invocation yet (maybe termbox calls it), I'm not able to send a pull request. Note that I'm using rustbox which depends on this crate. If the issue has already been fixed in the master branch, please consider pushing it to crates.io.

Edit: this seems relevant nsf/termbox#117

@jmacdonald
Copy link

@timvisee as you've referenced, the issue is upstream, in the termbox build script. You can patch it as part of the termbox build; here's an example of a sed-based patch step that'll do just that. You can use that repo as a temporary workaround.

I don't think it's a permanent solution, though. As an example, Arch Linux has taken to renaming the 2.x python executable python2, but macOS still uses python. Ideally, that termbox issue is addressed upstream and its build script works in both versions.

@jmacdonald
Copy link

@gchp this has been fixed via #19; we can close this issue now. 🙂

@panicbit
Copy link

panicbit commented Oct 4, 2018

@jmacdonald I think we should wait with that until the fix has been released and the new termbox-sys version is used by rustbox.

edit:
Nevermind, I thought this issue was in the rustbox repo, oops.

@vichvich4444
Copy link

Bump. Problem is still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants