Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client classes accessible to proxy/federated stores #2057

Open
d21211122 opened this issue Jan 30, 2019 · 6 comments
Open

Make client classes accessible to proxy/federated stores #2057

d21211122 opened this issue Jan 30, 2019 · 6 comments
Labels
federated-store Specific to/touches the federated-store module proxy-store Specific to/touches the proxy-store module

Comments

@d21211122
Copy link
Member

When deploying proxy or federated stores, you need to include the Operations, Functions and Data classes of the remote stores to enable the operations to be processed. If stores made a client jar available to clients, this mechanism could be automated, with stores able to dynamically update themselves as remote dependencies change or new stores are added.

@d21211122 d21211122 added p:normal needs-elaboration Requires further detail and explanation labels Jan 30, 2019
@n3101 n3101 added the federated-store Specific to/touches the federated-store module label Jul 29, 2020
@n3101
Copy link

n3101 commented Aug 24, 2021

@GCHQDeveloper404 Is this issue still relevant in the light of your v2/maestro changes? I.e. do I close it; push it to after v2.0 or what?

@n3101
Copy link

n3101 commented Aug 24, 2021

@GCHQDev404 Is this issue still relevant in the light of your v2/maestro changes? I.e. do I close it; push it to after v2.0 or what?

@n3101 n3101 added this to the v2.0.0 milestone Aug 24, 2021
@n3101 n3101 modified the milestones: v2.0.0, v2.0.0-alpha-0.5 Jan 19, 2022
@n3101
Copy link

n3101 commented Jan 19, 2022

After discussion, it appears this may partly have been covered by the maestro changes, so after those have been merged (alpha-4) test this one again as part of alpha-5 work and identify what remains to do.

@t92549
Copy link
Contributor

t92549 commented Jan 10, 2023

Is this made redundant by #2823?

@GCHQDev404
Copy link
Contributor

Yes.

But some examples to think about with #2823 vs this ticket.

example 1) FederatedStore receives an nonstandard operation, it simply forwards the operation (which was not able to be json deserialised) to remote graphs, which is good.
example 2) FederatedStore does know about the nonstandard operations and has a local handler/hook to do something interesting with it, which is good.
example 3) same as example 2 but someone updates the operation, now it can't be handled anymore. should it error or forward the operation.

So a choice needs to be made between the 2 or an alternative to both #2057 and #2823 is #2487

@GCHQDev404
Copy link
Contributor

This will be pushed back to after v2 and as a high priority because this will make management of multiple graphs easier.

@GCHQDev404 GCHQDev404 added proxy-store Specific to/touches the proxy-store module and removed needs-elaboration Requires further detail and explanation migration-required labels Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
federated-store Specific to/touches the federated-store module proxy-store Specific to/touches the proxy-store module
Projects
None yet
Development

No branches or pull requests

6 participants