Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-3073: Improve test coverage for GafferPopGraph #3117

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Gh-3073: Improve test coverage for GafferPopGraph #3117

merged 7 commits into from
Nov 28, 2023

Conversation

l46978
Copy link
Member

@l46978 l46978 commented Nov 23, 2023 •
edited by github-actions bot
Loading

@l46978 l46978 linked an issue Nov 23, 2023 that may be closed by this pull request
Improve Test Coverage for GafferPopGraph #3073
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d3f452) 65.79% compared to head (9889165) 66.01%.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #3117      +/-   ##
=============================================
+ Coverage      65.79%   66.01%   +0.22%     
  Complexity      2512     2512              
=============================================
  Files            909      909              
  Lines          29004    29004              
  Branches        3235     3235              
=============================================
+ Hits           19083    19147      +64     
+ Misses          8473     8419      -54     
+ Partials        1448     1438      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

GCHQDeveloper314
GCHQDeveloper314 previously requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pom changes are not required if Gaffer helper functions are used to load these files instead.

library/tinkerpop/src/test/resources/gafferpop-tinkerpop-modern.properties Outdated Show resolved Hide resolved
library/tinkerpop/pom.xml Outdated Show resolved Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraphTest.java Outdated Show resolved Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraphTest.java Outdated Show resolved Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraphTest.java Outdated Show resolved Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraphTest.java Outdated Show resolved Hide resolved
library/tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/GafferPopGraphTest.java Outdated Show resolved Hide resolved
@GCHQDeveloper314 GCHQDeveloper314 changed the title Gh-3073: improve test coverage for gafferpopgraph Gh-3073: Improve test coverage for GafferPopGraph Nov 27, 2023
@GCHQDeveloper314 GCHQDeveloper314 dismissed their stale review November 28, 2023 10:40

These changes have been made

@GCHQDeveloper314 GCHQDeveloper314 merged commit 7b5e9ff into develop Nov 28, 2023
25 checks passed
@GCHQDeveloper314 GCHQDeveloper314 deleted the gh-3073-improve-test-coverage-for-gafferpopgraph branch November 28, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t92549 t92549 t92549 approved these changes

@GCHQDeveloper314 GCHQDeveloper314 GCHQDeveloper314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Test Coverage for GafferPopGraph
3 participants
@l46978 @t92549 @GCHQDeveloper314