Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short Name Implementation #93

Merged
merged 1 commit into from
Sep 20, 2020

Conversation

kwongtn
Copy link
Contributor

@kwongtn kwongtn commented Aug 24, 2020

Implementation as per aura admin pull request #57 (formerly #52).
This allows short names to be used when required, giving better UI/UX. Long names clutter the interface and are quite a hassle to read.

If there are no short names defined, the long (original) name will be used instead.

Implementation as per aura admin pull request gdg-x#57 (formerly gdg-x#52).
This allows short names to be used when required, giving better UI/UX. Long names clutter the interface and are quite a hassle to read.

If there are no short names defined, the long (original) name will be used instead.
@kwongtn
Copy link
Contributor Author

kwongtn commented Aug 24, 2020

There's no "development" branch, therefore I opted to push to master branch

@agarwalbharat
Copy link
Member

Thank you @kwongtn, I have created a dev branch and changed the pull request to dev itself,

Copy link
Member

@agarwalbharat agarwalbharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

@agarwalbharat agarwalbharat added the enhancement New feature or request label Sep 20, 2020
@agarwalbharat agarwalbharat merged commit a84509e into gdg-x:dev Sep 20, 2020
@agarwalbharat agarwalbharat self-assigned this Sep 20, 2020
@agarwalbharat
Copy link
Member

agarwalbharat commented Sep 20, 2020

Thank you @kwongtn, the pull request looks good to me, I have merged the pull request to dev, and very soon we will merge it to master also,
so Thank you for your contribution to AURA

Regards
Bharat Agarwal

@kwongtn kwongtn deleted the shortNameImplementation branch September 21, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants