processing chapter #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to have another author to pass over this and probably do some integration. |
ljwolf
reviewed
Sep 18, 2020
There was a problem hiding this comment.
I've done some local review, and have some of these changes myself on my spatial data processing branch. I've run into issues using the new data to complete this chapter, and I've outlined where I hit these issues in the text.
|
|
||
| ```python | ||
|
|
||
| ``` |
| sheds.plot(ax=ax, edgecolor='grey', column='lintensity', legend=True, | ||
| scheme='fisher_jenks', | ||
| classification_kwds={'k':10}) | ||
| #cafes.plot(ax=ax, c='purple', alpha=0.5) |
There was a problem hiding this comment.
All of these repeated comments need to be removed.
| sheds.plot(ax=ax, edgecolor='grey', column='area', legend=True, | ||
| scheme='fisher_jenks', | ||
| classification_kwds={'k':10}) | ||
| #cafes.plot(ax=ax, c='purple', alpha=0.5) |
| # Display airports on top | ||
| #listings.plot(ax=ax, c='green') | ||
| sheds.plot(ax=ax, alpha=.7, edgecolor='white', column='listings', legend=True, scheme='quantiles') | ||
| #cafes.plot(ax=ax, c='purple', alpha=0.5) |
| # Display airports on top | ||
| #listings.plot(ax=ax, c='green') | ||
| sheds.plot(ax=ax, alpha=.7, edgecolor='white') | ||
| cafes.plot(ax=ax, c='purple', alpha=0.5) |
| ax.imshow(img, extent=ext) | ||
| # Display airports on top | ||
| sd_tracts.plot(ax=ax, alpha=0.6, edgecolor='lightgrey', | ||
| column='price', legend=True, scheme='quantiles') |
| ax.imshow(img, extent=ext) | ||
| # Display airports on top | ||
| sd_tracts.plot(ax=ax, alpha=0.6, color='green',edgecolor='lightgrey') | ||
| #listings.plot(ax=ax, c='green') |
| state of California: | ||
|
|
||
| ```python | ||
| tracts = '../data/sandiego/tl_2019_06_tract.shp' |
There was a problem hiding this comment.
This file is no longer provided. Further, using the acs_tracts_clean.shp data results in some screw-ups.
- The tracts don't need to be filtered anymore
- The CRS seems to be incorrectly set? I can't seem to get the two to agree on position correctly with a cursory investigation.
|
This now has all the references converted to the new jupyterbook format. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.