Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable "open with 'x'" feature for user defined file extensions in tree browser #789

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

aferust
Copy link

@aferust aferust commented Nov 14, 2018

Treebrowser has "open with glade" feature for .ui and .glade files in this fork. Tested on Ubuntu 16.04 LTS 64 bit and Windows 10 64bit (msys - mingw64).

@eht16
Copy link
Member

eht16 commented Nov 14, 2018

Do we want to add "Open with XY" for many different tools here?
Why is opening a file Glade in any way special? Next someone wants to add "Open with Firefox", then "Open with Gimp", then "Open with Foo", ...

Maybe a more generic approach like using "xdg-open" with a generic "Open" action is the better way?

@b4n
Copy link
Member

b4n commented Nov 15, 2018

Maybe a more generic approach like using "xdg-open" with a generic "Open" action is the better way?

"Open Externally" or such then, because I would expect the first action is to open it in Geany 😄 -- well, for text files at least.

@aferust
Copy link
Author

aferust commented Nov 15, 2018

I thought glade is in gnome ecosystem and it deserves a special action for opening glade files. Such as, intellij has "open in scenebuilder" feature for *.fxml files of javafx.

@elextr
Copy link
Member

elextr commented Nov 15, 2018

Glade may be in the Gnome ecosystem, but Geany is not. Geany is a somewhat portable application that uses GTK.

@aferust
Copy link
Author

aferust commented Nov 15, 2018

Ok guys. I agrree with you more generic approach would fit a wide range of requirements. Please forgive my ignorance daring a pull request for this. I am new to all gtk stuff, and I could not find a customizable behavior for opening those files using glade within geany. I know treebrowser has this: executable "%f", however It sets opening action for all extension types. May be it is my fault to unable to discover a pre-existing feature. I am open to get informed.

@aferust
Copy link
Author

aferust commented Nov 15, 2018

Now, users can associate files with any executable like:
geany:.glade;geany:.ui;notepad:.txt;winamp:.mp3
or whatever else
I hope everbody is happy now :)

@@ -62,8 +62,11 @@ static gboolean flag_on_expand_refresh = FALSE;
# define CONFIG_OPEN_TERMINAL_DEFAULT "cmd"
#endif

# define CONFIG_OPEN_EXT_USER_DEF_DEFAULT "notepad++:.txt;glade:.ui;glade:.glade"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first default here seems unusual...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@aferust aferust changed the title open with glade feature for .ui and .glade files in tree browser Customizable "open with 'x'" feature for user defined file extensions in tree browser Nov 16, 2018
@lpaulsen93
Copy link
Contributor

@aferust: I can resolve the conflicts if you like because they come from my PR #864. Doing that will change your PR and branch aferust:master.

@aferust
Copy link
Author

aferust commented Jul 12, 2019

@LarsGit223 : Yes, please go for it. I almost forgot that I did this PR a while ago. I am not sure what to do, I am not an expert on git system. Please tell me if you need me to do something.

@lpaulsen93
Copy link
Contributor

@aferust: done, you don't need to do anything.

@medovina: your the maintainer of treebrowser - have a look to maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants