-
Notifications
You must be signed in to change notification settings - Fork 624
Add keywords #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keywords #31
Conversation
The delay here seems to be none of the Geany devs use these desktops to test this. |
Gnome is requesting that Keywords be added to .desktop files, so can this patch be accepted now? |
@@ -10,3 +10,5 @@ Terminal=false | |||
Categories=GTK;Development;IDE; | |||
MimeType=text/plain;text/x-chdr;text/x-csrc;text/x-c++hdr;text/x-c++src;text/x-java;text/x-dsrc;text/x-pascal;text/x-perl;text/x-python;application/x-php;application/x-httpd-php3;application/x-httpd-php4;application/x-httpd-php5;application/xml;text/html;text/css;text/x-sql;text/x-diff; | |||
StartupNotify=true | |||
TargetEnvironment=Unity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore, since it's Xdg spec and Gnome-Shell uses it, I'll take it out
Also, the spec doesn't tell about it, but GNOME seems to use lowercase keywords, not sure it that matters. Anyway, you should re-do/squash the commits to have one single commit adding the Keywords line rather than 4 adding and removing various stuff. |
@mhall119 what's also the status of this, does it conflict with Pull Request 30? If it's just a matter of merging it into one commit, I can do that, but I have no clue about this stuff. I'm using Xfce 4.8 so not sure I can really test it. |
Adds searchable keywords to geany's .desktop file, used by Unity and Gnome-Shell.