Skip to content

Add keywords #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add keywords #31

wants to merge 4 commits into from

Conversation

mhall119
Copy link

Adds searchable keywords to geany's .desktop file, used by Unity and Gnome-Shell.

@elextr
Copy link
Member

elextr commented Sep 16, 2012

The delay here seems to be none of the Geany devs use these desktops to test this.

@mhall119
Copy link
Author

Gnome is requesting that Keywords be added to .desktop files, so can this patch be accepted now?

https://live.gnome.org/GnomeGoals/DesktopFileKeywords

@@ -10,3 +10,5 @@ Terminal=false
Categories=GTK;Development;IDE;
MimeType=text/plain;text/x-chdr;text/x-csrc;text/x-c++hdr;text/x-c++src;text/x-java;text/x-dsrc;text/x-pascal;text/x-perl;text/x-python;application/x-php;application/x-httpd-php3;application/x-httpd-php4;application/x-httpd-php5;application/xml;text/html;text/css;text/x-sql;text/x-diff;
StartupNotify=true
TargetEnvironment=Unity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed anymore, since it's Xdg spec and Gnome-Shell uses it, I'll take it out

@b4n
Copy link
Member

b4n commented Nov 17, 2012

Also, the spec doesn't tell about it, but GNOME seems to use lowercase keywords, not sure it that matters.

Anyway, you should re-do/squash the commits to have one single commit adding the Keywords line rather than 4 adding and removing various stuff.

@codebrainz
Copy link
Member

@mhall119 what's also the status of this, does it conflict with Pull Request 30?

If it's just a matter of merging it into one commit, I can do that, but I have no clue about this stuff. I'm using Xfce 4.8 so not sure I can really test it.

@codebrainz
Copy link
Member

Closing due to no response in 7 months and not being a huge killer feature.

@mhall119 Feel free to re-open or create a new cleaned up PR if you would like.

Related: PR #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants