Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add keywords #31

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants

Adds searchable keywords to geany's .desktop file, used by Unity and Gnome-Shell.

Member

elextr commented Sep 16, 2012

The delay here seems to be none of the Geany devs use these desktops to test this.

Gnome is requesting that Keywords be added to .desktop files, so can this patch be accepted now?

https://live.gnome.org/GnomeGoals/DesktopFileKeywords

@b4n b4n and 1 other commented on an outdated diff Nov 16, 2012

geany.desktop.in
@@ -10,3 +10,5 @@ Terminal=false
Categories=GTK;Development;IDE;
MimeType=text/plain;text/x-chdr;text/x-csrc;text/x-c++hdr;text/x-c++src;text/x-java;text/x-dsrc;text/x-pascal;text/x-perl;text/x-python;application/x-php;application/x-httpd-php3;application/x-httpd-php4;application/x-httpd-php5;application/xml;text/html;text/css;text/x-sql;text/x-diff;
StartupNotify=true
+TargetEnvironment=Unity
@b4n

b4n Nov 16, 2012

Owner

Why this line?

@mhall119

mhall119 Nov 16, 2012

Not needed anymore, since it's Xdg spec and Gnome-Shell uses it, I'll take it out

Owner

b4n commented Nov 17, 2012

Also, the spec doesn't tell about it, but GNOME seems to use lowercase keywords, not sure it that matters.

Anyway, you should re-do/squash the commits to have one single commit adding the Keywords line rather than 4 adding and removing various stuff.

Owner

codebrainz commented Jan 7, 2013

@mhall119 what's also the status of this, does it conflict with Pull Request 30?

If it's just a matter of merging it into one commit, I can do that, but I have no clue about this stuff. I'm using Xfce 4.8 so not sure I can really test it.

Owner

codebrainz commented Aug 15, 2013

Closing due to no response in 7 months and not being a huge killer feature.

@mhall119 Feel free to re-open or create a new cleaned up PR if you would like.

Related: PR #30

@codebrainz codebrainz closed this Aug 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment