Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support using system z,bz2 libraries #346

Merged
merged 2 commits into from
Mar 28, 2014
Merged

support using system z,bz2 libraries #346

merged 2 commits into from
Mar 28, 2014

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Mar 27, 2014

The default is to use the bundled libraries.

To use the system zlib and bzip2 change setup.cfg or use the --libraries z,bz2 parameter which will make our
custom build_ext command strip out the bundled versions.

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/344/

@mr-c
Copy link
Contributor Author

mr-c commented Mar 27, 2014

Hmm.. cppcheck found new code warnings (otherwise the build passed).

This will close #334

@ged-jenkins
Copy link

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/346/

@mr-c
Copy link
Contributor Author

mr-c commented Mar 28, 2014

test this please

@ged-jenkins
Copy link

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/360/

@mr-c
Copy link
Contributor Author

mr-c commented Mar 28, 2014

  • Is it mergable
  • Did it pass the tests?
  • N/A If it introduce new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at pep8/pylint, cppcheck, and
    make doc output. Use autopep8 and astyle -A10 if needed.
  • Is it documented in the Changelog?

luizirber added a commit that referenced this pull request Mar 28, 2014
support using system z,bz2 libraries
@luizirber luizirber merged commit 03bbeec into master Mar 28, 2014
@luizirber luizirber deleted the feature/system-libs branch March 28, 2014 01:50
nicolasbock pushed a commit to gentoo/sci that referenced this pull request Mar 31, 2014
…is available system-wide, upstream dib-lab/khmer#346

Package-Manager: portage-2.2.7
nicolasbock pushed a commit to gentoo/sci that referenced this pull request Mar 31, 2014
…is available system-wide, upstream dib-lab/khmer#346

Package-Manager: portage-2.2.7
luizirber added a commit that referenced this pull request Apr 1, 2014
support using system z,bz2 libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants