Custom options for kubeadm init #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option for additional kubeadm init options
kubeadm_init_opts default value
geerlingguy
requested changes
Sep 28, 2018
defaults/main.yml
Outdated
| @@ -12,6 +12,8 @@ kubernetes_packages: | |||
| kubernetes_role: master | |||
|
|
|||
| kubernetes_kubelet_extra_args: "" | |||
| # Any additional options for kubeadm init | |||
| kubeadm_init_opts: "" | |||
There was a problem hiding this comment.
Can you remove the comment above, and change the variable to:
kubernetes_kubeadm_init_extra_opts: ""
Then also add mention of it in the README.md file along with the other vars documented there (under the entry for kubernetes_kubelet_extra_args).
Thanks!
geerlingguy
approved these changes
Sep 28, 2018
|
Thanks! |
vulturm
pushed a commit
to vulturm/ansible-role-kubernetes
that referenced
this pull request
Mar 23, 2020
============================================= This represents the squashed history as it is not too relevant for us.. Below are all the commit messages: ============================================= Change a line to trigger a Travis CI build. A few small fixes for automated test builds. More updates to make things work better in various situations. Fix idempotence for web ui enablement. Fix dashboard UI service. Fix kube utils installation not working on Debian. Fix install on CentOS 7. Fix idempotence for Flannel networking task. Really fix idempotence for Flannel tasks, and get CentOS mostly working. Add more variables and docs. Space in the defaults file. [ci skip] Issue geerlingguy#3: Allow failures on CentOS 7 Travis CI build for now. Fixes geerlingguy#2: Make role work with nodes joining master. Spellcheck. Reload kubelet unit file if config is changed. Fixes geerlingguy#3: CentOS builds now passing. Change order when applying flannel templates. Issue geerlingguy#5: Add more configuration ability to default Flannel network manifests. Tick kubernetes stable version up from 1.10 to 1.11 Fixes geerlingguy#10: Set kubernetes_join_command more reliably. Fixes geerlingguy#15: Add kubelet extra args to the correct file for 1.11 and beyond. Fixes geerlingguy#16: CentOS 7 configuration of KUBELET_EXTRA_ARGS was broken. Update master-setup.yml Add option for additional kubeadm init options Update main.yml kubeadm_init_opts default value Changes for the comments under PR geerlingguy#19 Switch tests to use Molecule. Issue geerlingguy#17: Attempt to fix installation on CentOS. Issue geerlingguy#18: Attempt to fix version pinning issues on RedHat and Debian. Fix boolean on Debian setup, add more tests. Fixing lint issues incredibly sloppy day. fix typo kuberenetes PR geerlingguy#24 follow-up: Use verbosity instead of debug variable for debug info. Update tests for optimum efficiency. Fix YAML error in molecule config. Fixes failing Ubuntu 18.04 test. Fix some new ansible-lint issues. Issue geerlingguy#33: Set default Kubernetes version to 1.13.1. Bump Kubernetes RHEL package to 1.13.3. Fix ansible-lint issue - ignore rule 306. Update kubelet-setup.yml geerlingguy#42 Use same options for all tests and default to Ansible IP correctly. Remove unused tests. Fixes geerlingguy#54: Update to Kubernetes 1.15. Fixes geerlingguy#55: Support and test Debian 10 Buster. Fix typo referenced in geerlingguy#49 Update main.yml Create FUNDING.yml YAML syntax fix. Add kubernetes_join_command_extra_opts variable. calico cni choice PR geerlingguy#53 follow-up: Requested changes for simplicity. PR geerlingguy#53 follow-up: Add test for calico networking. PR geerlingguy#53 follow-up: Remove extra conditional. Bump to Kubernetes 1.16. Default to calico 3.10 manifest. PR geerlingguy#53 follow-up: Remove extra unneccessary loop. Fix README formatting. Add a test for CentOS 8. Update molecule configuration to work with 3.0. Update molecule configuration to work with 3.0. Update molecule configuration to work with 3.0. Make sure molecule lint script has set -e option. Add probot/stale configuration to repository for stale issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to add custom kubeadm init options such as --apiserver-cert-extra-sans via kubeadm_init_opts