PHP FPM , drupal module extlink, and target="_blank"

[ccjjmartin]

Background:
When I switched from using mod_php (apache) to php fpm I noticed all of my a tags had an attribute of target="_blank". This was not directly caused by DrupalVM it was caused by the contrib module extlink.

Questions:
Does something related to the proxy pass in the apache configuration make extlink think that every link is external?

Should this be fixed by DrupalVM or the contrib module?

Temporary Solution:
Disable the contrib module and links are normal again

I posted the question additionally in the contrib module issue queue:
https://www.drupal.org/node/2679977

[oxyc]

Doesn't seem likely. For debugging purposes what domain do you use and what does the following return if you run it in the browser console:

var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})((\.[a-z]{1,4})*)(:[0-9]{1,5})?$/;
console.log(window.location.host.replace(pattern, '$3$4'));
console.log(window.location.host.replace(pattern, '$1'));

[ccjjmartin]

@oxyc : The above code returned the exact same domain (with extlink disabled):
drupalvm.dev
drupalvm.dev

Do you think I need to reenable the broken module or it shouldn't matter?

[oxyc]

the exact same? That's odd, the first one should be drupalvm.dev while the second should be empty (or www). What browser are you using?

Edit: It shouldn't matter. All the logic of the module seems to be contained within JavaScript.

Edit 2: What does window.location.host in the browser console return?

[ccjjmartin]

"drupalvm.dev"

[ccjjmartin]

I am using google chrome

[oxyc]

Well that's just very strange. If i'm on http://drupalvm.dev and run

var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})((\.[a-z]{1,4})*)(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));

It returns

host: drupalvm.dev                                                     VM730:3
sub:                                                                   VM730:4 

Earlier did the second console.log return drupalvm.dev or did you mean the domain you were using?

If that's what you meant the only way I can see this happening based on the code is if the right-hand condition (extInclude && url.match(extInclude) evaluates to true at http://cgit.drupalcode.org/extlink/tree/extlink.js#n69.

This only evaluates to true if you've set a regex value for 'Include links matching the pattern' in the settings.

I dont believe Drupal VM could be the cause of this anyway.

[ccjjmartin]

var pattern = /^(([^\/:]+?.))([^.:]{4,})((.[a-z]{1,4}))(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));
VM16165:3 host: drupalvm.dev
VM16165:4 sub: drupalvm.dev

[oxyc]

How about

var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})(\.[a-z]{1,4})(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));

[ccjjmartin]

var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})((\.[a-z]{1,4}))(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));
VM16250:3 host: drupalvm.dev
VM16250:4 sub: drupalvm.dev

[oxyc]

So the issue is that the regex match fails and replaces nothing. Why this is the case I do not know :/ Looks correct to me.

[ccjjmartin]

@oxyc Thanks for your help, seems we know something about the issue now.

[oxyc]

Which operating system and chrome version are you using? I could test it in browserstack.

[ccjjmartin]

OSX Version 10.9.5
Chrome Version 48.0.2564.116 (64-bit) - Which is actively updating itself as we speak

[oxyc]

Tested on Mavericks with Chrome 48 and still unable to reproduce :/ You might try disabling extensions or trying some other browser. I'm out of ideas otherwise. Sorry, hope you get it working.

[ccjjmartin]

@oxyc Thanks again for your help. To give further information I don't think it is the browser or the JS or the regex. Here is a test from the same OS and browser against www.google.com and another test against drushcommands.com

var pattern = /^(([^\/:]+?.))([^.:]{4,})((.[a-z]{1,4}))(:[0-9]{1,5})?$/;
console.log(window.location.host.replace(pattern, '$3$4'));
console.log(window.location.host.replace(pattern, '$1'));
VM192:3 google.com
VM192:4 www.

var pattern = /^(([^\/:]+?.)*)([^.:]{4,})((.[a-z]{1,4}))(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));
VM121:3 host: drushcommands.com
VM121:4 sub:

I am thinking there is something that changed in the configuration of the server causing this because this site wasn't having any problems with DrupalVM before. The only change that I can isolate is mod_php versus php fpm.