Fix "invalid version" crash on startup #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the program crashing because of an uncaught exception. The bug was triggered by app_settings.last_launched_version being unset - which would always be the case when launching the program for the first time! The bug could also be triggered by manually changing the setting to an invalid value - e.g. by running: $ gsettings set com.github.geigi.cozy last-launched-version 'ayy lmao'
|
I encountered this bug after updating the OpenBSD package, I confirm it fixes #756 |
suve
force-pushed
the
fix-invalid-version-crash-at-startup
branch
2 times, most recently
from
ffc0c30
to
e42d2f6
Compare
The "packaging" module has deprecated its LegacyVersion identifier back in 2020, finally removing it in 2021. This causes cozy to crash when running against new version of said module, with the following error: > AttributeError: module 'packaging.version' > has no attribute 'LegacyVersion'
suve
force-pushed
the
fix-invalid-version-crash-at-startup
branch
from
e42d2f6
to
5dd970a
Compare
rdbende
approved these changes
Dec 9, 2023
Closed
This was referenced Feb 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the program crashing because of an uncaught exception. The bug was triggered by
app_settings.last_launched_versionbeing unset - which would always be the case when launching the program for the first time.The bug can also be triggered by manually changing the setting to an invalid value - e.g. by running:
Fixes issue #756.