Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in filtering and recents screen #853

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

Haaruun-I
Copy link
Contributor

@Haaruun-I Haaruun-I commented Jan 23, 2024

exactly as it says in the title, found these while working on doing issue #851 for myself

the "recents" screen (and probably the downlaoded screen) were getting ignored with the old conditional order
the criteria for a book to be "recent" were inconsistent

if you reset your progress in a book, it would show up in the "recent" screen but not count towards `is_any_book_in_progress`
@rdbende
Copy link
Collaborator

rdbende commented Jul 22, 2024

@geigi Do you have an idea, why the cozy-ci image doesn't pick up the updates to the requirements.txt from the master branch?

@geigi
Copy link
Owner

geigi commented Jul 22, 2024

It looks like the docker build Github Action cache didn't detect the change in the requirements.txt
I've cleared all caches, started a new build of the docker image and triggered the checks for this PR again. Seems like it fixed the problem :)

@rdbende
Copy link
Collaborator

rdbende commented Jul 22, 2024

Great! Thanks!

@rdbende rdbende merged commit 6389282 into geigi:master Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants