-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to reset book and remove from recents screen (#851) #946
Conversation
Thanks for your contribution :) Removing books from the recent page again is a nice feature I think. Some thoughts on the feature, haven't looked at the code yet:
|
This reverts the changes made in commit 32d69f7
Alright! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but it's mostly unneded code.
Thanks a lot for working on this, btw! I now have some hope that we can get some new contributors to the project 😊
Co-authored-by: Benedek Dévényi <rdbende@proton.me>
Co-authored-by: Benedek Dévényi <rdbende@proton.me>
Co-authored-by: Benedek Dévényi <rdbende@proton.me>
Thank you for the quick review! I use cozy allot, and I had some free time, so I just thought I'd help out a bit. :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Haaruun-I! I fixed the issue you had to work around in your "Temporary UI Bugfix". Sorry about that, it was my bad. Somehow I didn't commit that hunk in one of my PRs.
Thanks @rdbende! Dont know how I missed the |
Adds a 'Reset Book' button to both the context menu in the preview card and the book details page.
For now all it does is remove the 'last_played' time to get it off the recents screen, but i'm not sure if it should also reset the playback progress.
Not sure about the wording of the options though, reset sounds like it should also clear your playback, but 'remove from recents' is too long.
Heres it in action, still cant get the icons to work (#852) current 'reset' icon is the back arrow also used for the seek bar
Screencast.from.2024-07-25.20-52-40.mp4