AvgGMPE #5367
Merged
AvgGMPE #5367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmpagani
approved these changes
Dec 11, 2019
| <logicTreeBranch branchID="b25"> <uncertaintyModel>Campbell2003SHARE</uncertaintyModel> | ||
| <uncertaintyWeight>0.20</uncertaintyWeight> | ||
| </logicTreeBranch> | ||
| <logicTreeBranch branchID="b2"> |
There was a problem hiding this comment.
Why are you changing an existing test? Wouldn't it be better to add a new one?
There was a problem hiding this comment.
I am reusing an existing test because I wanted to check the difference between the hazard curves obtained from the original logic tree and from the collapsed one. The interesting thing is that in this test using the AvgGMPE produces the same mean curves as before, up to the numeric precision, even if in general the AvgGMPE does NOT produce the same mean curves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AvgGMPE computes the geometric mean of the underlying GMPEs, similarly to AvgSA. It is here for experimental purposes. When I will have time, I plan to see if it is usable for risk purposes (it it were, the problem of IMT-dependent weights would be solved, since we could use full enumeration after collapsing the gsim logic tree). This would solve #5354.