Fix typo in pkg-config file #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemarcano
reviewed
Mar 17, 2017
configure.ac
Outdated
|
|
||
| AX_CFLAGS_WARN_ALL | ||
| AX_COMPILER_FLAGS(,,,[-Wpedantic -Wall -Wextra -Wcast-align -Wcast-qual\ | ||
| AX_COMPILER_FLAGS([-Wpedantic -Wall -Wextra -Wcast-align -Wcast-qual\ |
There was a problem hiding this comment.
Why this change? Per the AX_COMPILER_FLAGS documentation, I'm purposefully setting the EXTRA-BASE-CFLAGS parameter for the following behavior (quoting the documentation):
The set of base and enabled flags can be augmented using the EXTRA-*-CFLAGS and EXTRA-*-LDFLAGS variables, which are tested and appended to the output variable if –enable-compile-warnings is not "no".
gemarcano
reviewed
Mar 17, 2017
configure.ac
Outdated
| AC_CHECK_FUNCS([malloc memmove memset strchr strtol]) | ||
|
|
||
| AX_CFLAGS_WARN_ALL | ||
| AX_COMPILER_FLAGS([-Wpedantic -Wall -Wextra -Wcast-align -Wcast-qual\ |
There was a problem hiding this comment.
No, those two are not equivalent at all. See the documentation on AX_CFLAGS_WARN_ALL.
|
Another comment, please use more descriptive commit messages and descriptions. As it stands, I'm not happy about the Autoconf file changes unless you can convince me about them, but I'll gladly accept the typo fix for the pkg-config file. |
|
Oh, I need to push my changes. AX_COMPILER_FLAGS gives me a syntax error no
matter what I do. In my working tree I removed it. (I get a different error
without autoconf-archive)
…On Thu, Mar 16, 2017, 10:23 PM Gabriel Marcano ***@***.***> wrote:
Another comment, please use more descriptive commit messages and
descriptions. As it stands, I'm not happy about the Autoconf file changes
unless you can convince me about them, but I'll gladly accept the typo fix
for the pkg-config file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH996Xprj8xfW3u3kmjpyeEW9qIDoVlmks5rme61gaJpZM4MeA-S>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.