Skip to content

Conversation

kpetku
Copy link
Contributor

@kpetku kpetku commented Mar 26, 2018

This improves upon #25 by adding an interval that can be shortened for tests. Feel free to reject and/or improve upon this if this approach is too messy.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 98.137% when pulling 12ee4dd on kpetku:master into a137208 on gempir:ping.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 98.137% when pulling 12ee4dd on kpetku:master into a137208 on gempir:ping.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 98.137% when pulling 12ee4dd on kpetku:master into a137208 on gempir:ping.

@coveralls
Copy link

coveralls commented Mar 26, 2018

Coverage Status

Coverage increased (+2.9%) to 100.0% when pulling 5050be0 on kpetku:master into a137208 on gempir:ping.

@kpetku kpetku changed the title add onNewReconnectMessage and improve test coverage WIP: add onNewReconnectMessage and improve test coverage Mar 26, 2018
@gempir gempir merged commit 1a84d1e into gempir:ping Mar 26, 2018
@gempir
Copy link
Owner

gempir commented Mar 26, 2018

Thank you. You're approach is clean and readable. I'll update the Go versions since 1.6 shouldn't be supported anyway anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants