[ENH] Add group_by parameter to structural_elements_from_borehole_set and plotting improvements #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added type hints to `active_grids` getter and setter, improving code readability and enabling better type checking. This enhancement ensures consistency in type usage for the `active_grids` property.
Introduce a `group_by` parameter with `Literal` typing in `structural_elements_from_borehole_set` for flexible grouping. Also, add dotenv initialization in the example script to manage environment variables.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Leguark
changed the title
Graphite Automations"Add gempy label" took an action on this PR • (05/10/25)1 label was added to this PR based on Miguel de la Varga's automation. |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for grouping boreholes by different criteria in the
structural_elements_from_borehole_setfunction by adding agroup_byparameter with options 'component lith' or 'lith_ids' (default). Also improved type hinting in the Grid class foractive_gridsproperty and added visualization code for contour plotting with custom color levels in the activator functions test module.Relates to #undefined
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).