-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper value import when pipe-separated entry in GPAD #31
Comments
Hi @dustine32 I'm re-opening this ticket because I think there may be a case-sensitivity issue with the references that use a DOI rather than a PMID. The abbreviation in the GPAD is actually 'DOI' rather than 'doi'. This model has two examples of where the DOI is not being included as the Source, probably because 'DOI' is upper case: At some point we will need to talk about what to display for a DOI in Noctua, but for now I think it's sufficient to just display the full string. |
Hey @vanaukenk , got this DOI showing up now in test model for WB:WBGene00015350: I just normalized the cases of the comparison strings. |
This looks good to me @dustine32 |
Update: 2021-03-02 |
Update from 2021-05-25 MOD imports call: Resurrect the reference preference code! Pick only one reference per annotation, preferring in this order (same as top comment but clarified here):
Confirming with @vanaukenk @ukemi @sabrinatoro |
|
@ukemi "MOD reference" would just be a list of all MOD reference prefixes? Is a comprehensive list available somewhere or should I just handle MGI, WB, ZFIN, SGD references for now? Also, is there an MGI case where the reference field would contain something like |
Hi @dustine32 I don't think we would have that example at MGI. They would all contain an MGI:MGI: value piped with one of the other types in the list. As for the prefixes, maybe in a YAML file somewhere, but that assumes that all databases use the same prefix for all database objects. This is a good point I hadn't considered. Maybe stick to your original plan? |
@ukemi Right, I agree we probably don't need to consider all MOD references prefixes right now. We can always implement some more nuanced logic later if needed though. |
Activate Ref Pref and add test for geneontology/gocamgen#31
From evidence rules 2 and 3 in the Google doc, we said that if there was more than one reference separated by a pipe, we would import only one reference using this descending list of preferences:
Order of preference for references:
PMID
GO_REF
doi
Other resource, e.g. MOD paper ID
Do we still want to do this?
Right now, it looks like both IDs (i.e. PMID and WBPaper ID) are being imported from the WB annotations, but only the WBPaper ID is displayed in the graph editor and both are exported in the Annotation Preview.
I can't quite make out how the paper ID is selected for the corresponding form view; both seem to be used but I can't discern a pattern.
The text was updated successfully, but these errors were encountered: