Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YeastPathways models have imaginary DB ref #254

Closed
suzialeksander opened this issue May 12, 2023 · 4 comments
Closed

YeastPathways models have imaginary DB ref #254

suzialeksander opened this issue May 12, 2023 · 4 comments
Assignees

Comments

@suzialeksander
Copy link

Less technical description:
Currently the DB ref for a model is something like SGD:SERSYN-PWY, which isn't actually a SGD ID & doesn't appear to be mapped to anything.

More technical description:
Referencing #37 as it contains some history on how the source field was populated. I'm now realizing this becomes the DB:Reference (aka PMID of evidenced literature) column in GPAD and so should follow the GPAD spec. To conform to the spec, this source needs to be a CURIE.

Note that source currently "works" for Reactome with an example CURIE Reactome:R-HSA-112303 correctly expanding and forwarding to its Reactome pathway page. However, does this "work" for the GPAD reference column? While syntactically correct, is this value meaningful as a literature reference?

For YeastPathways, conveniently, identifiers.org already has sgd.pathways registered so we can just use this. But do we need to add this to a context JSONLD such as go_context.jsonld? Like:

        "sgd.pathways": "https://identifiers.org/sgd.pathways/", 

Originally posted by @dustine32 in #126 (comment)

@suzialeksander
Copy link
Author

suzialeksander commented May 12, 2023

Two proposed options from call with @kltm and @dustine32 :

  1. Have SGD add these 220 pathways (names like LIPASYN-PWY-1 PWY-5703) to work in the yeastgenome.org search disambiguation (which is oddly in the dbxrefs.yaml under SGD_LOCUS):
  url_syntax: https://www.yeastgenome.org/search?q=[example_id]&is_quick=true
  example_id: SGD_PWY:LIPASYN-PWY-1
  example_url: https://www.yeastgenome.org/search?q=SGD_PWY:LIPASYN-PWY-1&is_quick=true
  1. Add a new namespace in the dbxrefs.yaml likeSGD_PWY: . This would go to https://pathway.yeastgenome.org/ and end up at https://pathway.yeastgenome.org/YEAST/NEW-IMAGE?type=PATHWAY&object=YEAST-SALV-PYRMID-DNTP

@suzialeksander suzialeksander self-assigned this May 12, 2023
@suzialeksander
Copy link
Author

suzialeksander commented May 18, 2023

SGD is opting for door no.2, changing dbxrefs.yaml. I'll put in a PR.

suzialeksander added a commit to geneontology/go-site that referenced this issue May 22, 2023
Adding new YeastPathway IDs for geneontology/pathways2GO#254
@suzialeksander
Copy link
Author

@dustine32 the SGD_PWY: should now be a real thing, let me know if you need anything else on my end

@dustine32
Copy link
Collaborator

@suzialeksander Awesome, thank you! I'll update the code and get some new models into noctua-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants