-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YeastPathways models have imaginary DB ref #254
Comments
Two proposed options from call with @kltm and @dustine32 :
|
SGD is opting for door no.2, changing dbxrefs.yaml. I'll put in a PR. |
suzialeksander
added a commit
to geneontology/go-site
that referenced
this issue
May 22, 2023
Adding new YeastPathway IDs for geneontology/pathways2GO#254
@dustine32 the |
@suzialeksander Awesome, thank you! I'll update the code and get some new models into noctua-dev. |
dustine32
added a commit
that referenced
this issue
May 25, 2023
This was referenced May 25, 2023
dustine32
added a commit
that referenced
this issue
May 25, 2023
Update SGD prefix in source to SGD_PWY for #254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Less technical description:
Currently the DB ref for a model is something like
SGD:SERSYN-PWY
, which isn't actually a SGD ID & doesn't appear to be mapped to anything.More technical description:
Referencing #37 as it contains some history on how the
source
field was populated. I'm now realizing this becomes the DB:Reference (aka PMID of evidenced literature) column in GPAD and so should follow the GPAD spec. To conform to the spec, thissource
needs to be a CURIE.Note that
source
currently "works" for Reactome with an example CURIEReactome:R-HSA-112303
correctly expanding and forwarding to its Reactome pathway page. However, does this "work" for the GPAD reference column? While syntactically correct, is this value meaningful as a literature reference?For YeastPathways, conveniently, identifiers.org already has
sgd.pathways
registered so we can just use this. But do we need to add this to a context JSONLD such as go_context.jsonld? Like:Originally posted by @dustine32 in #126 (comment)
The text was updated successfully, but these errors were encountered: