Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxon checks deactivated ? #51

Closed
pgaudet opened this issue Jun 3, 2016 · 1 comment
Closed

Taxon checks deactivated ? #51

pgaudet opened this issue Jun 3, 2016 · 1 comment

Comments

@pgaudet
Copy link
Collaborator

pgaudet commented Jun 3, 2016

Hello,

I am annotating PTHR11136 and I accidentally annotated the root of the tree with mitochondrion. Shouldn't this be forbidden ?

I have not yet seen the taxon constraints work as described here:
#34
Suzi you don't happen to have the example with which you tested this ?

Thanks,
Pascale

@selewis
Copy link
Contributor

selewis commented Jun 25, 2016

I had a long conversation with Chris on how the taxon ontology is actually organized and it was different that I had imagined, and actually much better as far as we're concerned.

Basically if any of the descendants may have a function (or be part of a process, or be found in a cell) then the annotation is allowable. If a particular branch has loss that capability then the "not found in" tag is added directly at that point. In light of this the PAINT+touchup code now allows these, but it should have also automatically annotated the loss at the bacteria clade (PTN000124089).

So this was a big omission on my part. I wrote the code, tested the code, and was calling the code, but only when the GAFs were first loaded! I forgot to add the call for when annotations were being carried out live by a curator. Big red face - but look for this in v2.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants