Skip to content

Fix Timezone Crash when Timezone does not exist #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2023
Merged

Fix Timezone Crash when Timezone does not exist #687

merged 3 commits into from
Mar 22, 2023

Conversation

ggallotti
Copy link
Member

@ggallotti ggallotti commented Mar 20, 2023 •
edited
Loading

Fix crash:

The datetime zone id 'America/Ciudad_Juarez' is not recognised
org.joda.time.DateTimeZone.forTimeZone (DateTimeZone.java:398)
com.genexus.specific.java.GXutil.Java2JodaTimeZone (GXutil.java:34)
com.genexus.specific.java.GXutil.DateTimeFromUTC (GXutil.java:51)
com.genexus.CommonUtil.DateTimeFromUTC (CommonUtil.java:937)
com.genexus.CommonUtil.ConvertDateTime (CommonUtil.java:910)
  • Bump joda timezone maven library
  • Do not crash Application when Timezone does not exists. Use default one.
  • Add UnitTests

@ggallotti ggallotti changed the title Fix timezone crash Fix Timezone Crash when Timezone does not exist Mar 20, 2023
@ggallotti ggallotti self-assigned this Mar 20, 2023
@ggallotti ggallotti marked this pull request as ready for review March 21, 2023 14:51
@ggallotti ggallotti requested a review from iroqueta March 21, 2023 14:51
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@ggallotti ggallotti merged commit 89c9032 into master Mar 22, 2023
@ggallotti ggallotti deleted the timezone branch March 22, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iroqueta iroqueta iroqueta approved these changes

Assignees

@ggallotti ggallotti

Labels
bot closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggallotti @genexusbot @iroqueta @cinthamo