Skip to content

fixes to datetimes CosmosDB #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 24, 2023
Merged

fixes to datetimes CosmosDB #690

merged 7 commits into from
Mar 24, 2023

Conversation

sjuarezgx
Copy link
Contributor

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx requested a review from gusbro March 22, 2023 13:34
gusbro
gusbro previously approved these changes Mar 22, 2023
View reviewed changes
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx requested a review from gusbro March 24, 2023 15:06
gusbro
gusbro requested changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@gusbro gusbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • java.sql.Timestamp.from(CommonUtil.nullDate().toInstant()).toString() should be defined in a constant and use that in getDate
  • the same for Date.from(CommonUtil.nullDate().toInstant()).getTime()

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx requested a review from gusbro March 24, 2023 15:43
gusbro
gusbro approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@gusbro gusbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I believe you are using some inconsistent DATE_FORMATTERS

@sjuarezgx sjuarezgx merged commit 69f571f into master Mar 24, 2023
@sjuarezgx sjuarezgx deleted the Issue102016_3 branch March 24, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusbro gusbro gusbro approved these changes

Assignees
No one assigned
Labels
bot closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sjuarezgx @genexusbot @gusbro @cinthamo