Fix socket closed in Android. Revert changes from 745 #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not close socket in sendRequest method.
tomas-sexenian
approved these changes
Aug 14, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (idx == addr_list.length-1) | ||
| throw se; // we tried them all | ||
| if (LocalAddr == null) | ||
| sock = new Socket(addr_list[idx], actual_port); |
Check failure
Code scanning / Fortify on Demand
Unreleased Resource: Sockets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problema:
Issue:
https://issues.genexus.com/viewissue.aspx?104236
Socket is closed al llamar httpclient a partir de offline
Solucion:
Hacer revert de algunos de los cambios en el PR :
#745
Cuando la funcion GetSocket o sendRequest es usada, no cerrar el socket que se utiliza, porque luego es consultado para ver los resultados del httpclient.
Nota: Seguramente hay que liberar el socket al destruir el httpclient o la conexion. Eso no lo toco ahora para evitar otro broken.