When adding attachments to emails, input streams are closed before being used #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting from someone from the organization to review this |
tomas-sexenian
added a commit
that referenced
this pull request
Jul 8, 2024
Changes implemented in client generated PR #879
|
Closing this PR as PR's from outside the organization do not have access to our Github secrets and variables and therefore automatic checks cannot run. Implementing and referencing this changes in PR #882 |
tomas-sexenian
added a commit
that referenced
this pull request
Aug 19, 2024
Changes implemented in client generated PR #879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the legacy SMTPSession implementation (necessary in our case) the input stream used to read the attachments' content is closed prior to being used.
The problem seems to have been introduced when fixing security issues, probably an automated tool indicated that the streams were not being closed.
The fix moves the finally block that contains the close operation so that the stream usage occurs before that block.