Skip to content

Conversation

bsastregx
Copy link
Collaborator

Changes in this PR:

Mercury

  • Remove --ch-dialog-max-inline-size variable defined at the dialogelement. This variable was duplicated, and it should only be defined at the host context.

before:

.dialog {
  --ch-dialog-max-block-size: 600px;
  --ch-dialog-max-inline-size: 800px;
  --ch-dialog-min-block-size: 200px;
  --ch-dialog-min-inline-size: 300px;
}
.dialog::part(dialog) {
  --ch-dialog-max-inline-size: 800px; /* duplicated */
}

after:

.dialog {
  --ch-dialog-max-block-size: 600px;
  --ch-dialog-max-inline-size: 800px;
  --ch-dialog-min-block-size: 200px;
  --ch-dialog-min-inline-size: 300px;
}

…al reference

Using `"@genexus/mercury": "*"` to reference the local Mercury package was causing an issue.
… dialog element

`--ch-dialog-max-inline-size: 800px;` was duplicated. It should only be defined at the `:host`
@bsastregx bsastregx added fix Bug fix pull request mercury Changes related to Mercury design system target: minor This PR is targeted for the next minor release labels Aug 19, 2025
@bsastregx bsastregx changed the title [common][showcase] Remove --ch-dialog-max-inline-size from the dialog element [common][showcase] Remove --ch-dialog-max-inline-size from the dialog element Aug 19, 2025
@bsastregx bsastregx merged commit 0f09853 into main Aug 19, 2025
6 checks passed
@bsastregx bsastregx deleted the dialog/fix-max-inline-size branch August 19, 2025 20:47
@bsastregx bsastregx changed the title [common][showcase] Remove --ch-dialog-max-inline-size from the dialog element [mercury][dialog] Remove --ch-dialog-max-inline-size from the dialog element Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix pull request mercury Changes related to Mercury design system target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant