[mercury][dialog] Use mixins for the header close button (reusulting in having focus style now), move padding-block from the header to the header caption, to avoid excesive height.
#624
+55
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include mixins for the header button (a mixin for tertiary button, and a mixin for icon-only) - Set a min-block-size on the header and remove the header padding (to prevent excesive height due to header padding + close button padding). - Set padding-block on the header caption (to prevent text overlap with header block borders on excesive large heading captions).
bsastregx
added
fix
bsastregx
changed the title
[mercury][dialog] Use mixins for the header button, move padding-block from the header to the header caption.
bsastregx
changed the title
[mercury][dialog] Use mixins for the header button, move padding-block from the header to the header caption.[mercury][dialog] Use mixins for the header close button (reusulting in having focus style now), move padding-block from the header to the header caption, to avoid excesive height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes on this PR:
Mercury
button-tertiaryandbutton-icon-onlymixins to the header close button.min-block-sizefor the header and remove its padding-block to avoid excessive height caused by combined header and close button padding.padding-blockto the header caption to prevent text from overlapping the header borders when captions are large.