Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: CdtDbtInd vs ChrgInclInd #116

Open
geekdevs opened this issue Jan 25, 2022 · 0 comments
Open

Bug: CdtDbtInd vs ChrgInclInd #116

geekdevs opened this issue Jan 25, 2022 · 0 comments

Comments

@geekdevs
Copy link

It looks like there's a confusion between CdtDbtInd (which is "CRDT" or "DBIT") and ChrgInclInd (with could only be "true" or "false") here:

if (isset($chargesRecord->CdtDbtInd) && (string) $chargesRecord->CdtDbtInd === 'true') {

Also, is it possible to somehow retrieve "CdtDbtInd" individually from this DTO?

sbuerk added a commit to impact-media-GmbH/genkgo-camt that referenced this issue May 25, 2023
The credit-debit-identifier (CrdDbtInd) have been used for
several details, e.g. amount, to proper represent values.
The information itself is not added.

As it could not be reliable retrieved from subvalues what
the original state was, this change now adds that detail
directly to the transaction detail.

Test fixture files are updated to contain the added fields.

Resolves: genkgo#146
Related: genkgo#116
sbuerk added a commit to impact-media-GmbH/genkgo-camt that referenced this issue May 25, 2023
The credit-debit-identifier (CrdDbtInd) have been used for
several details, e.g. amount, to proper represent values.
The information itself is not added.

As it could not be reliable retrieved from subvalues what
the original state was, this change now adds that detail
directly to the transaction details and the entry itself.

Test fixture files are updated to contain the added fields.

Resolves: genkgo#146
Related: genkgo#116
PowerKiKi pushed a commit that referenced this issue May 30, 2023
The credit-debit-identifier (CrdDbtInd) have been used for
several details, e.g. amount, to proper represent values.
The information itself is not added.

As it could not be reliable retrieved from subvalues what
the original state was, this change now adds that detail
directly to the transaction details and the entry itself.

Test fixture files are updated to contain the added fields.

Resolves: #146
Related: #116
sbuerk added a commit to impact-media-GmbH/genkgo-camt that referenced this issue Jun 5, 2023
The credit-debit-identifier (CrdDbtInd) have been used for
several details, e.g. amount, to proper represent values.
The information itself is not added.

As it could not be reliable retrieved from subvalues what
the original state was, this change now adds that detail
directly to the transaction details and the entry itself.

Test fixture files are updated to contain the added fields.

Resolves: genkgo#146
Related: genkgo#116

Conflicts:
	src/DTO/Entry.php
	src/DTO/EntryTransactionDetail.php
	src/Decoder/EntryTransactionDetail.php
Alvyre pushed a commit to stadline/camt that referenced this issue Oct 9, 2024
The credit-debit-identifier (CrdDbtInd) have been used for
several details, e.g. amount, to proper represent values.
The information itself is not added.

As it could not be reliable retrieved from subvalues what
the original state was, this change now adds that detail
directly to the transaction details and the entry itself.

Test fixture files are updated to contain the added fields.

Resolves: genkgo#146
Related: genkgo#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant