Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding several Camt054.v4 Options #44

Merged
merged 16 commits into from
May 31, 2017
Merged

Conversation

teslina
Copy link
Contributor

@teslina teslina commented Mar 1, 2017

Adding

$xmlDetail->Amt 
$xmlDetail->RltdDts->AccptncDtTm
$xmlDetail->Chrgs
$entry->Chrgs

This is my very first contribution on GitHub, so please bear with me ;-)

Adding function addAmount 
( $xmlDetail->AmtDtls->TxAmt->Amt is not available in PostFinance camt.054.v4 Feed )
Adding methods getAmount & setAmount
Adding Amount, since AmountDetails ( $xmlDetail->AmtDtls->TxAmt->Amt ) is not available in PostFinance camt.054.v4 Feed
@frederikbosch
Copy link
Contributor

@teslina Thank you for taking the time to create a PR to this library. I am happy to help with your first PR. This library contains unit tests to test that the code actually works. Have you ever worked with PHPUnit? Before I can merge it in, your code should have some testing coverage. In any case, the current tests should pass. As you can see on Travis this is not the case at the moment. Good luck!

@teslina
Copy link
Contributor Author

teslina commented Mar 1, 2017

@frederikbosch Thank you :-) No, I haven't worked with PHPUnit before. I did some testing with another, independent script, which I haven't commited. But I'll look into PHPUnit and check if I'm able to add some proper tests :)

@sdespont
Copy link
Contributor

Hi @teslina,

I will certainly use this project for Camt054.v4 files decoding in the next weeks. As the maintainers cannot ensure that the library is fully functional for this kind of file, can you tell me if you manage to use it?

Best regards,

Sébastien

@frederikbosch
Copy link
Contributor

@Einenlum This PR looks OK to me. Only additions. Nothing more. Merge it in?

@Einenlum Einenlum merged commit bf9940c into genkgo:master May 31, 2017
@teslina
Copy link
Contributor Author

teslina commented May 31, 2017

Hi @sdespont
I haven't completed my work on decoding the new Postfinance Camt054.v4 files yet - unfortunately, I had to put my work on ice for the past few weeks. But you certainly can use this library. If some options are missing, simply add them :)

@sdespont
Copy link
Contributor

@teslina Thank you for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants