-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding several Camt054.v4 Options #44
Conversation
Adding function addAmount ( $xmlDetail->AmtDtls->TxAmt->Amt is not available in PostFinance camt.054.v4 Feed )
Adding methods getAmount & setAmount
Adding Amount, since AmountDetails ( $xmlDetail->AmtDtls->TxAmt->Amt ) is not available in PostFinance camt.054.v4 Feed
@teslina Thank you for taking the time to create a PR to this library. I am happy to help with your first PR. This library contains unit tests to test that the code actually works. Have you ever worked with PHPUnit? Before I can merge it in, your code should have some testing coverage. In any case, the current tests should pass. As you can see on Travis this is not the case at the moment. Good luck! |
@frederikbosch Thank you :-) No, I haven't worked with PHPUnit before. I did some testing with another, independent script, which I haven't commited. But I'll look into PHPUnit and check if I'm able to add some proper tests :) |
Hi @teslina, I will certainly use this project for Camt054.v4 files decoding in the next weeks. As the maintainers cannot ensure that the library is fully functional for this kind of file, can you tell me if you manage to use it? Best regards, Sébastien |
@Einenlum This PR looks OK to me. Only additions. Nothing more. Merge it in? |
Hi @sdespont |
@teslina Thank you for your feedback. |
Adding
This is my very first contribution on GitHub, so please bear with me ;-)