Cleanup code in the Default data source #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes proper handling of $@
This matches the behavior of all other data sources
Data sources now commit in the same order. Make UR::DataSource::Default always go last. The new Genome::Sys::CommitAction API requires this to ensure database-type data sources are saved and committed before CommitActions are run.
|
👍 |
|
CI, test this |
1 similar comment
|
CI, test this |
brummett
added a commit
that referenced
this pull request
May 15, 2015
Cleanup code in the Default data source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more tests to the default data source
Makes commit() a separate phase to match how other data sources work.
Data sources now commit in the same order they sync.
These changes are necessary to implement a new API that replaces Context commit observers in Genome.