-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for calculated_default attribute #70
Conversation
@@ -808,6 +815,13 @@ sub create_entity { | |||
$params = { $rule->params_list }; ; | |||
} | |||
|
|||
my %default_value_requires_call = %$initial_default_value_requires_call; | |||
for my $name (keys %$initial_default_value_requires_call) { | |||
if ($params->{$name}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be if (exists $params->{$name}) {
to allow specifying a false-y value in create()
Needs some documentation in UR/Object/Type/Initializer.pod |
|
Brainstorming...
|
FYI, I implemented |
I pushed commits to address feedback so far (besides picking a better name than |
Pushed commits to rename |
+1 after tests pass |
add support for calculated_default attribute
From the POD,