This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is a sketch of a slightly different approach to |
Here is an example of building a signed/encrypted JWT programatically. |
def _execute_target(self, *args, **kwargs): | ||
try: | ||
id_token = self._extract_id_token() | ||
except Exception as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're probably still working on this, but you can define a tuple of exception classes that you want to catch, then use it here:
_INVALID_AUTH_EXCEPTIONS = (MissingAutheHeadersError, MalformedAccessTokenError, InvalidSerialization)
<snip>
try:
id_token = self._extract_id_token()
except _INVALID_AUTH_EXCEPTIONS as e:
return self.exception_map[e.__class__]
except:
LOG.exception('Bad things happened')
<snip>
davidlmorton
added a commit
that referenced
this pull request
Sep 11, 2014
Flesh out protected_endpoint decorator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll continue to add to this pull-request.