Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnetcore-sdk-bin updates (may 2020 updates, .net 5.0 support) #470

Closed
wants to merge 4 commits into from

Conversation

ngg
Copy link
Contributor

@ngg ngg commented Mar 16, 2020

there are 4 changes:

  • envvar setting for older versions
  • 3.0 is no longer ~amd64 because it has reached EOL
  • may 2020 updates: 2.1 is updated to 2.1.806, 3.1 is updated to 3.1.300
  • 5.0.100-preview.4 is added

@ngg ngg changed the title dotnetcore-sdk-bin updates (.net 5.0 support) dotnetcore-sdk-bin updates (march 2020 updates, .net 5.0 support) Mar 25, 2020
@ngg
Copy link
Contributor Author

ngg commented Mar 30, 2020

@cnd Can you please check this PR?

@ngg ngg changed the title dotnetcore-sdk-bin updates (march 2020 updates, .net 5.0 support) dotnetcore-sdk-bin updates (may 2020 updates, .net 5.0 support) May 13, 2020
@ngg
Copy link
Contributor Author

ngg commented Jun 4, 2020

@cnd can I do something to get this merged? Is there something you do not like?

@cnd
Copy link
Contributor

cnd commented Jun 8, 2020

@ngg yes, it's very hard to merge PR with many commits because of very awkward git policy. (I don't like to add sign-off to every commit like a monkey during interactive rebase)

to make live easier I should move that repository from "official" but than all users will need to migrate

for now maybe squash all commits into one for future Pull Requests

@gentoo-bot gentoo-bot closed this in 0a2e142 Jun 8, 2020
@ngg
Copy link
Contributor Author

ngg commented Jun 8, 2020

Ok, in the future I'll create separate PRs for multiple commits or squash them together if that makes sense. Should I also add signed-off-by lines like when I make PRs to the main gentoo repo?

@cnd
Copy link
Contributor

cnd commented Jun 8, 2020

yes it does but for that I also should request for infra to register you as official collaborator with push access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants