-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnetcore-sdk-bin updates (may 2020 updates, .net 5.0 support) #470
Conversation
@cnd Can you please check this PR? |
@cnd can I do something to get this merged? Is there something you do not like? |
@ngg yes, it's very hard to merge PR with many commits because of very awkward git policy. (I don't like to add sign-off to every commit like a monkey during interactive rebase) to make live easier I should move that repository from "official" but than all users will need to migrate for now maybe squash all commits into one for future Pull Requests |
Ok, in the future I'll create separate PRs for multiple commits or squash them together if that makes sense. Should I also add signed-off-by lines like when I make PRs to the main gentoo repo? |
yes it does but for that I also should request for infra to register you as official collaborator with push access |
there are 4 changes: