Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-sound/id3ed: fix LICENSE, SRC_URI and HOMEPAGE + EAPI7 revbump #11016

Closed
wants to merge 2 commits into from
Closed

media-sound/id3ed: fix LICENSE, SRC_URI and HOMEPAGE + EAPI7 revbump #11016

wants to merge 2 commits into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented Feb 10, 2019

Hi,

This PR updates media-sound/id3ed for EAPI7 alongside with a few other fixes.
Please review.

@mm1ke
media-sound/id3ed: fix LICENSE, SRC_URI and HOMEPAGE
7288850 
Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com>
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: media-sound/id3ed

media-sound/id3ed: @gentoo/sound

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Feb 10, 2019
a17r
a17r suggested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No DEPEND? We've had this bevore.

@mm1ke
Copy link
Contributor Author

mm1ke commented Feb 10, 2019

No DEPEND? We've had this bevore.

Damn, sorry, i've got that wrong again.
So if DEPEND is set, RDEPEND automatically inherits DEPEND, but not vice versa which is why i would need to set DEPEND, or in my case here: DEPEND=${RDEPEND}...
I've decided to keep the original and just set DEPEND :)

@a17r
Copy link
Member

a17r commented Feb 10, 2019

So if DEPEND is set, RDEPEND automatically inherits DEPEND, but not vice versa which is why

Nothing is done automatically here.

@mm1ke
media-sound/id3ed: EAPI7 revbump
daf0507 
Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com>
@mm1ke
Copy link
Contributor Author

mm1ke commented Feb 10, 2019

@a17r
Ok, i think i didn't just mingled with RDEPEND/DEPEND, but also had a another misunderstanding.
I've checked the runtime deps and RDEPEND=${DEPEND} needs to be set.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-02-10 16:02 UTC
Newest commit scanned: daf0507
Status: ✅ good

No issues found

@mm1ke mm1ke deleted the id3ed-UaAekpPn branch March 1, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a17r a17r a17r requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mm1ke @gentoo-bot @a17r @gentoo-repo-qa-bot