Asterisk g729 update #13718
Asterisk g729 update #13718
Conversation
gentoo-bot
added
need assignment
jkroonza
force-pushed
the
asterisk-g729-update
branch
from
5b5c2ea
to
d9f8f40
Compare
gentoo-bot
changed the title
Pull Request assignmentSubmitter: @jkroonza net-misc/asterisk-g729: At least one of the listed packages is maintained entirely by non-GitHub developers! Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
jkroonza
force-pushed
the
asterisk-g729-update
branch
from
d9f8f40
to
375311e
Compare
There was a problem hiding this comment.
* Messages for package net-misc/asterisk-g729-13.0.3.1.9:
* QA Notice: Files built without respecting CFLAGS have been detected
* Please include the following list of files in your report:
* /usr/sbin/asthostid
* /usr/sbin/astregister
Looks good.
I'm still not happy with the 11 ebuild, why touch it at all if the intention is to remove it in one month. But I can cherry-pick 1st and 3rd commit if you fix QA_* flags and homepage redirection.
Builds fine.
Signed-off-by: Jaco Kroon <jaco@uls.co.za>
jkroonza
force-pushed
the
asterisk-g729-update
branch
from
375311e
to
09c21cb
Compare
| QA_FLAGS_IGNORED_amd64="usr/lib64/asterisk/modules/codec_g729a.so" | ||
| QA_FLAGS_IGNORED_x86="usr/lib/asterisk/modules/codec_g729a.so" | ||
| QA_PREBUILT="usr/sbin/asthostid usr/sbin/astregister" |
There was a problem hiding this comment.
I wasn't even aware that this _prefix is available for QA_FLAGS_IGNORED. However it seems to break PKG_PREBUILT. You'll have to use $(get_libdir) here, which in turns means you have to move this to pkg_setup(). You know, you could test whether this works or not with https://wiki.gentoo.org/wiki/Package_testing#make.conf these settings.
There was a problem hiding this comment.
Tony (I suspect) did those, way back from CVS days.
Ok, so reading the manpage, QA_PREBUILT is appended onto a number of other QA_ flags, including QA_FLAGS_IGNORED (I'm unable to locate the code that does this appending).
Assuming that the QA process will use QA_FLAGS_IGNORED_${ARCH} if it exists, and fall back to QA_FLAGS_IGNORED I can see how that won't work properly. If it however checks both (which in my opinion would be the sane thing to do) this should work correctly.
Based on the code:
7 local qa_var="QA_FLAGS_IGNORED_${ARCH/-/_}"
8 eval "[[ -n ${!qa_var} ]] && QA_FLAGS_IGNORED=("${${qa_var}[@]}")"
(from /usr/lib/portage/python{2.7,3.6}/install-qa-check.d/10ignored-flags)
This does indeed look like an override. Personally I would make that = on line 8 a += so that _${ARCH} gets appended instead of discarded. Your opinion.
I do, however, not see any QA warnings, with or without the QA_PREBUILT line at all, the only way I can provoke a warning at all is with commenting the QA_FLAGS_IGNORED_* variables.
I've already had most of that make.conf sample exported into the environment before.
I've just dropped the PREBUILT line completely as it seems to have no effect. If you're getting a QA warning, please do paste the warning here, I'm not getting one that I can find.
There was a problem hiding this comment.
* Messages for package net-misc/asterisk-g729-13.0.3.1.9:
* QA Notice: Files built without respecting CFLAGS have been detected
* Please include the following list of files in your report:
* /usr/sbin/asthostid
* /usr/sbin/astregister
There was a problem hiding this comment.
sigh ... would you mind emailing me the applicable emerge --info for that? Something is obviously different between our environments.
This includes: version bump to EAPI=7. Added -* to keywods (Downloads only available for x86 and amd64) All http:// to https:// Update homepage to avoid redirect (Digium vs Sangoma). Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Jaco Kroon <jaco@uls.co.za>
jkroonza
force-pushed
the
asterisk-g729-update
branch
from
09c21cb
to
a9e7595
Compare
|
@jkroonza I use a Qemu image to test packages, here's my "vanilla" settings that I use to upgrade the image or download any dependencies of testable packages: and here are the sourced settings when testing a single ebuild contribution: Here's the diff: --- emerge_info_vanilla.txt 2020-01-30 11:50:26.860571523 +0000
+++ emerge_info_testing.txt 2020-01-30 11:50:26.456575843 +0000
@@ -1,7 +1,7 @@
Portage 2.3.86 (python 3.6.10-final-0, default/linux/amd64/17.1/desktop, gcc-9.2.0, glibc-2.30-r3, 5.5.0-pf1-x86_64 x86_64)
=================================================================
System uname: Linux-5.5.0-pf1-x86_64-x86_64-AMD_Ryzen_7_3700X_8-Core_Processor-with-gentoo-2.6
-KiB Mem: 32868320 total, 16818108 free
+KiB Mem: 32868320 total, 16811580 free
KiB Swap: 0 total, 0 free
Timestamp of repository gentoo: Wed, 29 Jan 2020 03:06:23 +0000
Head commit of repository gentoo: 49f8d24a0f55928b37e116ea89f4e86aaa93a3eb
@@ -44,12 +44,12 @@
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe -frecord-gcc-switches"
DISTDIR="/var/cache/distfiles"
-EMERGE_DEFAULT_OPTS="--jobs=8"
+EMERGE_DEFAULT_OPTS="--jobs=1"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=native -O2 -pipe -frecord-gcc-switches"
-FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
+FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms split-elog split-log strict strict-keepdir test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=native -O2 -pipe -frecord-gcc-switches"
-GENTOO_MIRRORS="http://mirror.mdfnet.se/gentoo"
+GENTOO_MIRRORS=""
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0"
LINGUAS=" en en_US en-US fi sv "
@@ -58,6 +58,6 @@
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/tmp"
-USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli crypt cups cxx dbus dri dts dvd dvdr emboss encode exif flac fortran gdbm gif gpm gtk iconv icu ipv6 jpeg lcms ldap libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses nptl ogg opengl openmp pam pango pcre pdf png policykit ppds qt5 readline sdl seccomp spell split-usr ssl startup-notification svg systemd tcpd tiff truetype udev udisks unicode upower usb vorbis wxwidgets x264 xattr xcb xml xv xvid zlib" ABI_X86="64 32" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev joystick" KERNEL="linux" L10N="en en_US en-US fi sv" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AMDGPU BPF" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_5 python3_6 python3_7 python3_8" RUBY_TARGETS="ruby24 ruby25" SANE_BACKENDS="pixma" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
+USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit crypt cups cxx dbus doc dri dts dvd dvdr emboss encode examples exif flac fortran gdbm gif gpm gtk iconv icu ipv6 jpeg lcms ldap libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds qt5 readline sdl seccomp spell split-usr ssl startup-notification svg tcpd test tiff truetype udev udisks unicode upower usb vorbis wxwidgets x264 xattr xcb xml xv xvid zlib" ABI_X86="64 32" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev joystick" KERNEL="linux" L10N="en en_US en-US fi sv" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AMDGPU BPF" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_5 python3_6 python3_7 python3_8" RUBY_TARGETS="ruby24 ruby25" SANE_BACKENDS="pixma" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset: CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS(For some reason I have |
asterisk-g729 updates to EAPI=7, and commit asterisk 13 variant into ::gentoo.