Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-apps/moreutils: Respect compiler environment #15703

Closed
wants to merge 1 commit into from
Closed

sys-apps/moreutils: Respect compiler environment #15703

wants to merge 1 commit into from

Conversation

thesamesam
Copy link
Member

Now respects CC as well as CFLAGS.

Thanks-to: Agostino Sarubbo ago@gentoo.org
Closes: https://bugs.gentoo.org/721394
Package-Manager: Portage-2.3.99, Repoman-2.3.22
Signed-off-by: Sam James (sam_c) sam@cmpct.info

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @thesamesam
Areas affected: ebuilds
Packages affected: sys-apps/moreutils

sys-apps/moreutils: @thesamesam, @gentoo/proxy-maint

Linked bugs

Bugs linked: 721394

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 8, 2020
@thesamesam
Copy link
Member Author

@Whissi

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-08 05:00 UTC
Newest commit scanned: b1dd491
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4676747e3f/output.html

@Whissi
Copy link
Contributor

Whissi commented May 8, 2020

I just found

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/isutf8

@thesamesam
Copy link
Member Author

thesamesam commented May 9, 2020 •
edited
Loading

I will investigate a bit more soon, but does this mean I need tc-export for LDFLAGS? Or is there a better way?

@Whissi
Copy link
Contributor

Whissi commented May 9, 2020

No, LDFLAGS are already exported.

BTW: You linked to git master. It's already fixed upstream via https://git.joeyh.name/index.cgi/moreutils.git/commit/?id=6c88aaa6b828d7bd7c1dccb3b842594d48c1764c. It's not fixed in https://git.joeyh.name/index.cgi/moreutils.git/tree/is_utf8/Makefile?h=0.63 ...

@thesamesam
Copy link
Member Author

D'oh. That's why I was so confused, I thought it was always exported, but I couldn't see any other way given the Makefile looked right. Silly.

@thesamesam
sys-apps/moreutils: Respect compiler environment
4aeef8d 
Now respects CC as well as CFLAGS.

This patch is taken from upstream, not yet in
a release.

Thanks-to: Agostino Sarubbo <ago@gentoo.org>
Closes: https://bugs.gentoo.org/721394
Package-Manager: Portage-2.3.99, Repoman-2.3.22
Signed-off-by: Sam James (sam_c) <sam@cmpct.info>
@thesamesam
Copy link
Member Author

I've used the upstream patch and am now using the magic LDFLAGS value to detect these problems in future.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-05-09 10:50 UTC
Newest commit scanned: 4aeef8d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fe051a0fcb/output.html

@gentoo-bot gentoo-bot closed this in 47abea9 May 9, 2020
@thesamesam thesamesam deleted the moreutils-respect-cc branch May 29, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thesamesam @gentoo-bot @gentoo-repo-qa-bot @Whissi