Bump GStreamer to 1.18.4

[lanodan]

eclass thread: https://archives.gentoo.org/gentoo-dev/message/569c767d69849e1328eda2ae04f511e7

Closes: https://bugs.gentoo.org/690468
Closes: https://bugs.gentoo.org/756298
Bug: https://bugs.gentoo.org/780744

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-03-23 10:39 UTC
Newest commit scanned: d52d930
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8293a84d33/output.html

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-03-23 12:34 UTC
Newest commit scanned: b9649ee
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2bdc119568/output.html

[orbea]

This PR would close this issue.

https://bugs.gentoo.org/780744

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-05-02 13:44 UTC
Newest commit scanned: b0252c8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5d14c33e1b/output.html

[lanodan]

As installing all the split packages is a bit of a dependency hell I only tested the ones I use on my desktop (running in Sway), which are:

media-libs/gst-plugins-bad
media-libs/gst-plugins-base
media-libs/gst-plugins-good
media-libs/gst-plugins-ugly
media-libs/gstreamer
media-plugins/gst-plugins-assrender
media-plugins/gst-plugins-dash
media-plugins/gst-plugins-faad
media-plugins/gst-plugins-hls
media-plugins/gst-plugins-libav
media-plugins/gst-plugins-libde265
media-plugins/gst-plugins-libnice
media-plugins/gst-plugins-meta
media-plugins/gst-plugins-modplug
media-plugins/gst-plugins-mpg123
media-plugins/gst-plugins-opus
media-plugins/gst-plugins-rtmp
media-plugins/gst-plugins-soup
media-plugins/gst-plugins-srtp
media-plugins/gst-plugins-v4l2
media-plugins/gst-plugins-vaapi
media-plugins/gst-plugins-vpx
media-plugins/gst-plugins-webrtc

[lanodan]

This PR would close this issue.

https://bugs.gentoo.org/780744

Maybe, I'm not sure how this failure even really happened but I haven't seen it while using gstreamer-1.18.x on my machines. I'd say it's up for gstreamer@ to make it close or not.

[orbea]

It failed here for me:

../gst-plugins-good-1.18.4/meson.build:1:0: ERROR: Value "yes" (of type "string") for combo option "X11 ximagesrc plugin" is not one of the choices. Possible choices are (as string): "enabled", "disabled", "auto".

Can just change all of the usex invocations to use enabled and disabled.

Also with ffmpeg--9999 gst-plugins-libav fails.

The first failure is fixed upstream:

https://gitlab.freedesktop.org/tpm/gst-libav/-/commit/801dc93b790e9a96aa437a3f344214170c0bd540

And the second is reported here:

https://gitlab.freedesktop.org/gstreamer/gst-libav/-/issues/97

[lanodan]

It failed here for me:

../gst-plugins-good-1.18.4/meson.build:1:0: ERROR: Value "yes" (of type "string") for combo option "X11 ximagesrc plugin" is not one of the choices. Possible choices are (as string): "enabled", "disabled", "auto".

Can just change all of the usex invocations to use enabled and disabled.

Already fixed (as I discovered the media-plugins/gst-plugins-ximagesrc package while bumping the splits).

Also with ffmpeg--9999 gst-plugins-libav fails.

The first failure is fixed upstream:

https://gitlab.freedesktop.org/tpm/gst-libav/-/commit/801dc93b790e9a96aa437a3f344214170c0bd540

Thanks, will test this patch.

And the second is reported here:

https://gitlab.freedesktop.org/gstreamer/gst-libav/-/issues/97

Thanks

[lanodan]

Found the ABI issue with _gst_debug, should be fixed as now I'm only finding new gstreamer symbols in libgstreamer-1.0.so).

Autoconf had:

• --disable-debug: disable addition of -g debugging info
• --disable-gst-debug: disable debugging subsystem (GST_DISABLE_GST_DEBUG_DEFINE in gst/gstconfig.h.in)

And I badly assumed that --disable-debug in autoconf ebuild ended up as -Dgst_debug=false on meson.

Applied:

diff --git a/eclass/gstreamer-meson.eclass b/eclass/gstreamer-meson.eclass
index 130e4c673f7..c3c97db0690 100644
--- a/eclass/gstreamer-meson.eclass
+++ b/eclass/gstreamer-meson.eclass
@@ -252,10 +252,6 @@ gstreamer_multilib_src_configure() {
                gst_conf+=( -Dschemas-compile=disabled )
        fi
 
-       if grep -q "option('gst_debug'" "${EMESON_SOURCE}"/meson_options.txt ; then
-               gst_conf+=( -Dgst_debug=false )
-       fi
-
        if grep -q "option('examples'" "${EMESON_SOURCE}"/meson_options.txt ; then
                gst_conf+=( -Dexamples=disabled )
        fi

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-05-30 00:19 UTC
Newest commit scanned: f27c80c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/463f39daad/output.html

[thesamesam]

Aaaand merged. Huge, huge thanks to @lanodan for his dedicated work here.

Thanks to everyone who's tested so far as well as leio and all other developers for reviewing!

Please file bugs on Bugzilla with as much information as you can if you hit any issues. Be patient with us as we work out the kinks.

[Ri0n]

@lanodan , thanks a lot! You did a great job! Could you also take a look at https://bugs.gentoo.org/749357 ? :-)

[thesamesam]

@Ri0n Linked in the bug: #20388.