Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11-misc/slop: bump to 7.6/EAPI 8 #23077

Closed
wants to merge 1 commit into from
Closed

x11-misc/slop: bump to 7.6/EAPI 8 #23077

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 25, 2021

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Marco Scardovi marco@scardovi.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @scardracs
Areas affected: ebuilds
Packages affected: x11-misc/slop

x11-misc/slop: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 25, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-25 13:10 UTC
Newest commit scanned: 06700cb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9723ae7bc8/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some annoying dep-finding going on. With -opengl I get:

>>> Unpacking source...
>>> Unpacking slop-7.6.tar.gz to /var/tmp/portage/x11-misc/slop-7.6/work
>>> Source unpacked in /var/tmp/portage/x11-misc/slop-7.6/work
>>> Preparing source in /var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6 ...
 * Source directory (CMAKE_USE_DIR): "/var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6"
 * Build directory  (BUILD_DIR):     "/var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6_build"
 * Applying slop-7.5-missing-header.patch ...
 [ ok ]
 * Hardcoded definition(s) removed in CMakeLists.txt:
 *  set(CMAKE_BUILD_TYPE Debug CACHE STRING "Choose the type of build (Debug or R
 *    set(CMAKE_INSTALL_PREFIX "/usr" CACHE PATH "..." FORCE)
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6 ...
 * Source directory (CMAKE_USE_DIR): "/var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6"
 * Build directory  (BUILD_DIR):     "/var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6_build"
cmake -C /var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6_build/gentoo_common_config.cmake -G Ninja -DCMAKE_INSTALL_PREFIX=/usr -DSLOP_OPENGL=no -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_TOOLCHAIN_FILE=/var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6_build/gentoo_toolchain.cmake  /var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6
loading initial cache file /var/tmp/portage/x11-misc/slop-7.6/work/slop-7.6_build/gentoo_common_config.cmake
-- The CXX compiler identification is GNU 11.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/x86_64-pc-linux-gnu-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found GLM: /usr/include  
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find X11 (missing: X11_X11_INCLUDE_PATH)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake/Modules/FindX11.cmake:457 (find_package_handle_standard_args)
  CMakeLists.txt:68 (find_package)

But after I enable +opengl and it installs bunch of deps,

Calculating dependencies  ... done!
[binary  N     ] x11-base/xorg-proto-2021.5-1::gentoo  USE="-test" 0 KiB
[binary  N     ] x11-libs/xtrans-1.4.0-1::gentoo  USE="-doc" 0 KiB
[binary  N     ] x11-libs/libdrm-2.4.108-1::gentoo  USE="-libkms -valgrind" ABI_X86="32 (64) (-x32)" VIDEO_CARDS="amdgpu radeon (-exynos) (-freedreno) -intel -nouveau (-omap) (-tegra) (-vc4) (-vivante) -vmware" 0 KiB
[binary  N     ] x11-libs/libxshmfence-1.3-r2-1::gentoo  ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] sys-devel/llvm-common-13.0.0-2::gentoo  0 KiB
[binary  N     ] x11-libs/libICE-1.0.10-1::gentoo  USE="ipv6" ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] x11-libs/libXfixes-6.0.0-1::gentoo  USE="-doc" ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] x11-libs/libXrender-0.9.10-r2-1::gentoo  ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] media-libs/libglvnd-1.3.4-1::gentoo  USE="X -test" ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] x11-libs/libXi-1.8-1::gentoo  USE="-doc" ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] x11-libs/libXxf86vm-1.1.4-r2-1::gentoo  USE="-doc" ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] sys-devel/llvm-13.0.0-2:13::gentoo  USE="gold libffi ncurses -debug -doc -exegesis -libedit -test -xar -xml -z3" ABI_X86="32 (64) (-x32)" LLVM_TARGETS="AMDGPU BPF (X86) -AArch64 (-ARC) -ARM -AVR (-CSKY) -Hexagon -Lanai (-M68k) -MSP430 -Mips -NVPTX -PowerPC -RISCV -Sparc -SystemZ (-VE) -WebAssembly -XCore" 0 KiB
[binary  N     ] sys-devel/llvmgold-13-r1-1::gentoo  0 KiB
[binary  N     ] media-libs/mesa-21.3.0-1::gentoo  USE="X classic gallium gles2 llvm zstd -d3d9 -debug -gles1 -lm-sensors -opencl -osmesa (-selinux) -test -unwind -vaapi -valgrind -vdpau -vulkan -vulkan-overlay -wayland -xa -xvmc -zink" ABI_X86="32 (64) (-x32)" CPU_FLAGS_X86="sse2" VIDEO_CARDS="radeonsi -crocus (-freedreno) -i915 -i965 -intel -iris (-lima) -nouveau (-panfrost) -r100 -r200 -r300 -r600 -radeon (-v3d) (-vc4) -virgl (-vivante) -vmware" 0 KiB
[binary  N     ] virtual/opengl-7.0-r2-2::gentoo  ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] media-libs/glu-9.0.2-1::gentoo  USE="-static-libs" ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] virtual/glu-9.0-r2-1::gentoo  ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] x11-libs/libSM-1.2.3-r1-1::gentoo  USE="ipv6 uuid -doc" ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] x11-libs/libXt-1.2.1-1::gentoo  USE="-doc -test" ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] x11-libs/libXmu-1.1.3-1::gentoo  USE="ipv6 -doc" ABI_X86="32 (64) (-x32)" 0 KiB
[binary  N     ] media-libs/glew-2.2.0-1:0/2.2::gentoo  USE="-doc -static-libs" ABI_X86="32 (64) (-x32)" 0 KiB
[ebuild  N     ] x11-misc/slop-7.6:0/7.6::gentoo  USE="opengl" 0 KiB

it passes even with -opengl. So that

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find X11 (missing: X11_X11_INCLUDE_PATH)

is looking for more that's listed outside your !opengl. Could you check?

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Marco Scardovi <marco@scardovi.com>
@ghost ghost requested a review from juippis November 28, 2021 12:34
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-28 12:45 UTC
Newest commit scanned: 48a8a6a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a477a79de4/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the drop of -9999 to be in a separate commit but this works fine too. Thanks!

@ghost ghost deleted the slop branch November 29, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants